From: Martin Michlmayr <tbm@cyrius.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: linux-mtd@lists.infradead.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
buytenh@wantstofly.org
Subject: Re: Oops parsing empty RedBoot partition with 2.6.20-rc7
Date: Fri, 2 Feb 2007 19:14:41 +0100 [thread overview]
Message-ID: <20070202181441.GA2034@deprecation.cyrius.com> (raw)
In-Reply-To: <20070202175755.GG24587@deprecation.cyrius.com>
* Martin Michlmayr <tbm@cyrius.com> [2007-02-02 18:57]:
> It was caused by:
>
> [MTD] redboot partition combined fis / config problem
And this fixes it for me:
[MTD] Don't oops when the RedBoot partition table is empty
This fixes a regression with the RedBoot parsing code introduced by
commit 0b47d654089c5ce3f2ea26a4485db9bcead1e515
Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
--- a/drivers/mtd/redboot.c
+++ b/drivers/mtd/redboot.c
@@ -122,7 +122,7 @@ static int parse_redboot_partitions(struct mtd_info *master,
}
}
break;
- } else {
+ } else if (buf[i].size != -1) {
/* re-calculate of real numslots */
numslots = buf[i].size / sizeof(struct fis_image_desc);
}
--
Martin Michlmayr
http://www.cyrius.com/
next prev parent reply other threads:[~2007-02-02 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 15:56 Oops parsing empty RedBoot partition with 2.6.20-rc7 Martin Michlmayr
2007-02-02 17:22 ` Williams, Dan J
2007-02-02 17:57 ` Martin Michlmayr
2007-02-02 18:14 ` Martin Michlmayr [this message]
2007-02-09 15:07 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070202181441.GA2034@deprecation.cyrius.com \
--to=tbm@cyrius.com \
--cc=buytenh@wantstofly.org \
--cc=dan.j.williams@intel.com \
--cc=linux-mtd@lists.infradead.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox