From: Jason Lunz <lunz@falooley.org>
To: "Jörn Engel" <joern@lazybastard.org>
Cc: Felix Fietkau <nbd@openwrt.org>, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] block2mtd oops in erase function.
Date: Tue, 20 Feb 2007 16:35:29 -0500 [thread overview]
Message-ID: <20070220213528.GA7764@metaxa.reflex> (raw)
In-Reply-To: <20070220105306.GC10455@lazybastard.org>
On Tue, Feb 20, 2007 at 10:53:07AM +0000, Jörn Engel wrote:
> Cool! Would you mind also trying two more patches? One of them just
> removes a compile warning if CONFIG_MODULE=n, the other rips out the
> readahead code, which should give a nice performance boost on USB
> sticks, MMC/SD, etc. Mounting JFFS2 in particular should be faster.
I'm using jffs2 on block2mtd. I'd be happy to test any patches you have.
The readahead-disable one in particular is interesting - i ended up
patching the source to get rid of the warning about readahead past
end-of-disk. And mounting jffs2-on-block2mtd-on-ide-flash is quite slow.
Jason
---
drivers/mtd/devices/block2mtd.c | 1 -
1 file changed, 1 deletion(-)
Index: linux-2.6.20-rc5-uml/drivers/mtd/devices/block2mtd.c
===================================================================
--- linux-2.6.20-rc5-uml.orig/drivers/mtd/devices/block2mtd.c
+++ linux-2.6.20-rc5-uml/drivers/mtd/devices/block2mtd.c
@@ -63,7 +63,6 @@
for (i = 0; i < PAGE_READAHEAD; i++) {
pagei = index + i;
if (pagei > end_index) {
- INFO("Overrun end of disk in cache readahead\n");
break;
}
page = radix_tree_lookup(&mapping->page_tree, pagei);
next prev parent reply other threads:[~2007-02-20 21:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-19 21:29 [PATCH] block2mtd oops in erase function Felix Fietkau
2007-02-19 22:20 ` Jörn Engel
2007-02-19 22:30 ` Jörn Engel
2007-02-20 2:27 ` Felix Fietkau
2007-02-20 10:53 ` Jörn Engel
2007-02-20 21:35 ` Jason Lunz [this message]
2007-02-20 21:55 ` Jörn Engel
[not found] ` <20070221030254.GA11044@avocado.homenet>
2007-02-21 14:47 ` Jörn Engel
2007-02-21 15:42 ` Jason Lunz
2007-02-21 16:02 ` Jörn Engel
2007-02-21 20:26 ` Jason Lunz
2007-02-21 21:43 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070220213528.GA7764@metaxa.reflex \
--to=lunz@falooley.org \
--cc=joern@lazybastard.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox