Re: [PATCH] block2mtd oops in erase function.

Jason Lunz
2007-02-20T21:35:47Z

On Tue, Feb 20, 2007 at 10:53:07AM +0000, Jörn Engel wrote:
> Cool! Would you mind also trying two more patches? One of them just
> removes a compile warning if CONFIG_MODULE=n, the other rips out the
> readahead code, which should give a nice performance boost on USB
> sticks, MMC/SD, etc. Mounting JFFS2 in particular should be faster.

I'm using jffs2 on block2mtd. I'd be happy to test any patches you have.

The readahead-disable one in particular is interesting - i ended up
patching the source to get rid of the warning about readahead past
end-of-disk. And mounting jffs2-on-block2mtd-on-ide-flash is quite slow.

Jason

---
drivers/mtd/devices/block2mtd.c | 1 -
1 file changed, 1 deletion(-)

Index: linux-2.6.20-rc5-uml/drivers/mtd/devices/block2mtd.c
===================================================================
--- linux-2.6.20-rc5-uml.orig/drivers/mtd/devices/block2mtd.c
+++ linux-2.6.20-rc5-uml/drivers/mtd/devices/block2mtd.c
@@ -63,7 +63,6 @@
for (i = 0; i < PAGE_READAHEAD; i++) {
pagei = index + i;
if (pagei > end_index) {
- INFO("Overrun end of disk in cache readahead\n");
break;
}
page = radix_tree_lookup(&mapping->page_tree, pagei);