From: Arnd Bergmann <arnd@arndb.de>
To: Richard Purdie <rpurdie@openedhand.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
dwmw2@infradead.org, linux-mtd@lists.infradead.org,
kernel list <linux-kernel@vger.kernel.org>,
Hugh Dickins <hugh@veritas.com>
Subject: Re: [PATCH 8/9] mtd: Allow mtd block device drivers to have a custom ioctl function
Date: Sun, 4 Mar 2007 15:20:42 +0100 [thread overview]
Message-ID: <200703041520.43245.arnd@arndb.de> (raw)
In-Reply-To: <1172850902.11149.130.camel@localhost.localdomain>
On Friday 02 March 2007 16:55:02 Richard Purdie wrote:
> Allow mtd block drivers to customise their ioctl functions. Also
> allow the drivers to obtain the gendisk struct since ioctl
> functions can need this.
Are you sure that this is a good idea? I'd rather not open
up this method of letting the individual drivers to bad things.
> This also moves the mtd ioctl functions from locked to unlocked.
> As far as I can see, nothing in the mtd code has locking problems.
This part looks fine to me.
Arnd <><
next prev parent reply other threads:[~2007-03-04 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-02 15:55 [PATCH 8/9] mtd: Allow mtd block device drivers to have a custom ioctl function Richard Purdie
2007-03-04 14:20 ` Arnd Bergmann [this message]
2007-03-05 2:23 ` Kyungmin Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703041520.43245.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=dwmw2@infradead.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nickpiggin@yahoo.com.au \
--cc=rpurdie@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox