Re: [PATCH] LogFS take three

Jan Engelhardt
2007-05-19T09:42:01Z

On May 19 2007 02:15, Rob Landley wrote:
>> > +
>> > +static inline struct logfs_inode *LOGFS_INODE(struct inode *inode)
>> > +{
>> > + return container_of(inode, struct logfs_inode, vfs_inode);
>> > +}
>>
>> Do these need to be uppercase?
>
>I'm trying to keep it clear in my head...
>
>When do you need to say __always_inline and when can you get away with
>just saying "static inline"?

When using "static inline", the compiler may ignore the inline keyword
(it's just a hint), and leave the function as a standalone function.

When CONFIG_FORCED_INLINING is active, and it is by default, inline is
always substituted by __always_inline, to be on the safe side. Some code
needs to be always inline; but not all code has been checked whether it
is safe to go from __always_inline to inline.

Jan
--