Re: [PATCH] LogFS take three

Roland Dreier
2007-05-16T02:38:07Z

There are rather a lot of of FIXME comments, including scary stuff like

> + /*
> + * FIXME: this cannot be right but it does "fix" a bug of i_count
> + * dropping too low. Needs more thought.
> + */
> + atomic_inc(&old_dentry->d_inode->i_count);

and

> +int __logfs_write_inode(struct inode *inode)
> +{
> + /*
> + * FIXME: Those two inodes are 512 bytes in total. Not good to
> + * have on the stack. Possibly the best solution would be to bite
> + * the bullet and do another format change before release and
> + * shrink the inodes.
> + */
> + struct logfs_disk_inode old, new;

are you going to change the format? or fix this some other way?

I think a sweep through the code searching for FIXME and at least
rewriting all such comments to look like stuff that can be deferred
would be warranted ;)

- R.