Re: [PATCH] LogFS take three

Jörn Engel
2007-05-16T19:28:41Z

On Wed, 16 May 2007 19:17:18 +0000, Pavel Machek wrote:
>
> In kernel fsck....
>
> > --- /dev/null 2007-04-18 05:32:26.652341749 +0200
> > +++ linux-2.6.21logfs/fs/logfs/progs/fsck.c 2007-05-15 00:54:22.000000000 +0200
> > @@ -0,0 +1,332 @@
> > +/*
> > + * fs/logfs/prog/fsck.c - filesystem check
> > + *
> > + * As should be obvious for Linux kernel code, license is GPLv2
> > + *
> > + * Copyright (c) 2005-2007 Joern Engel
> > + *
> > + * In principle this could get moved to userspace. However it might still
> > + * make some sense to keep it in the kernel. It is a pure checker and will
> > + * only report problems, not attempt to repair them.
> > + */
>
> Is there version that repairs?

No.

> BUG is not right thing to do for media error.

I know. Top 3 items of my todo list are:
- Handle system crashes
- Add second journal
- Error handling

> > +
> > +#if 0
> > +/* rootdir */
>
> Please just delete it, not comment it out like this.

That will get resurrected, even before the move to userspace. I had to
change the filesystem format for compression support and this is an
artifact of the transition phase.

Jörn

--
Ninety percent of everything is crap.
-- Sturgeon's Law