Re: [PATCH] LogFS take three

Rob Landley
2007-05-19T06:17:14Z

On Tuesday 15 May 2007 4:37 pm, Andrew Morton wrote:

> > +static inline struct logfs_super *LOGFS_SUPER(struct super_block *sb)
> > +{
> > + return sb->s_fs_info;
> > +}
> > +
> > +static inline struct logfs_inode *LOGFS_INODE(struct inode *inode)
> > +{
> > + return container_of(inode, struct logfs_inode, vfs_inode);
> > +}
>
> Do these need to be uppercase?

I'm trying to keep it clear in my head...

When do you need to say __always_inline and when can you get away with just
saying "static inline"?

(I'm attempting to write documentation on a topic I don't understand. Best
way to learn it, I've found...)

> > +     buf = kmap(page);
> > +     ret = logfs_write_buf(inode, index, buf);
> > +     kunmap(page);
>
> kmap() is lame.  The preferred approach would be to pass the page* down to
> the lower layers and to use kmap_atomic() at the lowest possible point.

Um, would I read about this in DMA-mapping.txt or cachetlb.txt? (I don't
think it's fujitsu/frv/mmu-layout.txt)

Rob