Re: [PATCH] LogFS take three

John Stoffel
2007-05-15T19:11:27Z

>>>>> "JÃ¶rn" == JÃ¶rn Engel <joern@lazybastard.org> writes:

JÃ¶rn> [ I have put everyone that gave comments to the last patch on Cc:. Hope
JÃ¶rn> that doesn't offend anyone. ]

JÃ¶rn> Add LogFS, a scalable flash filesystem.

I've been semi watching this, and the only comment I really can give
is that I hate the name. To me, logfs implies a filesystem for
logging purposes, not for Flash hardware with wear leveling issues to
be taken into account.

I admit, neither does JFFS2 or YAFFS really do justice either. And I
do realize your filesystem design is pretty neat.

Also, having scanned through the code, I find the name "cookie" using
in logfs_inode(), logfs_iput(), logfs_iget() to be badly named. It
should really be something like *cached_inode, which would seem to
give more natural semantics of

if (cached_inode)
do_cached_inode_ops(...)
else
do_inode_ops(...)

But hey, I'm not a kernel programmer, so feel free to discount
comments.

John