Re: Review status (Re: [PATCH] LogFS take three)

Evgeniy Polyakov
2007-05-17T16:04:31Z

Hi Jörn.

Is logfs 32bit fs or 674bit, since although you use 64bit values for
offsets, area management and strange converstions like described below
from offset into segment number are performed in 32bit?
Is it enough for SSD for example to be 32bit only? Or if it is 64bit,
could you please explain logic behind area management?

I've found that you store segment numbers as 32bit values (for example
in prepare_write()), and convert requested 64bit offset into segment
number via superblock's s_segshift.
This conversation seems confusing to me in case of real 64bit offsets.
For example this one obtained via prepare_write:

7 1 logfs_prepare_write 78 fs/logfs/file.c
8 2 logfs_readpage_nolock 20 fs/logfs/file.c
9 1 logfs_read_block 351 fs/logfs/readwrite.c
10 1 logfs_read_loop 139 fs/logfs/readwrite.c
11 2 logfs_segment_read 108 fs/logfs/readwrite.c
12 1 wbuf_read 289

u32 segno = ofs >> super->s_segshift;

ofs is originally obtained from inode's li_data array, which is filled
with raw segment numbers which can be 64bit (here is another issue,
since logfs_segment_write() returns signed, so essentially logfs is
63bit filesystem).

But here I've came to area management in logfs, and found that it is
32bit only, for example __logfs_segment_write()/__logfs_get_free_bytes()
returns signed 32 bit value (so it is reduced to 31 bit), which is then
placed into li_data as 64bit value. The latter
(__logfs_get_free_bytes()) truncates 64bit data value obtained via
dev_ofs() into signed 32 bit value.

--
Evgeniy Polyakov