From: Ivan Kuten <ivan.kuten@promwad.com>
To: Andrew Victor <andrew@sanpeople.com>, dwmw2@infradead.org
Cc: linux-mtd@lists.infradead.org
Subject: Re: PATCH: at91_nand rdy_pin fix
Date: Thu, 24 May 2007 14:35:58 +0300 [thread overview]
Message-ID: <20070524143558.0bdae1f0@newbox> (raw)
In-Reply-To: <1179992828.13098.26.camel@fuzzie.sanpeople.com>
Hi again,
Corrected according to Andrew's comments:
The patch below fixes nand driver for AT91 boards which do not have NAND R/B signal
connected to gpio (rdy_pin is not connected).
Best regards,
Ivan
Signed-off-by: Ivan Kuten <ivan.kuten@promwad.com>
Acked-by: Andrew Victor <andrew@sanpeople.com>
diff -urN linux-2.6.22-rc1-at91.orig/drivers/mtd/nand/at91_nand.c linux-2.6.22-rc1-at91/drivers/mtd/nand/at91_nand.c
--- linux-2.6.22-rc1-at91.orig/drivers/mtd/nand/at91_nand.c 2007-05-24 14:09:12 +0300
+++ linux-2.6.22-rc1-at91/drivers/mtd/nand/at91_nand.c 2007-05-24 14:09:42 +0300
@@ -128,7 +128,10 @@
nand_chip->IO_ADDR_R = host->io_base;
nand_chip->IO_ADDR_W = host->io_base;
nand_chip->cmd_ctrl = at91_nand_cmd_ctrl;
- nand_chip->dev_ready = at91_nand_device_ready;
+
+ if (host->board->rdy_pin)
+ nand_chip->dev_ready = at91_nand_device_ready;
+
nand_chip->ecc.mode = NAND_ECC_SOFT; /* enable ECC */
nand_chip->chip_delay = 20; /* 20us command delay time */
On 24 May 2007 09:47:08 +0200
Andrew Victor wrote:
> hi Ivan,
>
> > - nand_chip->dev_ready = at91_nand_device_ready;
> > +
> > + if (host->board->rdy_pin)
> > + nand_chip->dev_ready = at91_nand_device_ready;
> > + else
> > + nand_chip->dev_ready = NULL;
>
> Patch looks correct.
>
> Since the at91_nand_host structure is allocated with kzalloc(),
> nand_chip->dev_ready is already initialized to NULL.
> So we don't really need the "else" part.
>
>
> Regards,
> Andrew Victor
>
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2007-05-24 11:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 21:53 PATCH: at91_nand rdy_pin fix Ivan Kuten
2007-05-24 7:47 ` Andrew Victor
2007-05-24 8:14 ` Ivan Kuten
2007-05-24 11:35 ` Ivan Kuten [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-06-28 19:14 Ivan Kuten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070524143558.0bdae1f0@newbox \
--to=ivan.kuten@promwad.com \
--cc=andrew@sanpeople.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).