Re: [PATCH][update] jffs2_gcd_mtd3, Stopping kernel threads timed out

Josh Boyer
2007-06-26T15:36:52Z

On Tue, 2007-06-26 at 16:39 +0200, Uli Luckas wrote:
> On Tuesday, 26. June 2007, Josh Boyer wrote:
> > On Tue, 2007-06-26 at 15:06 +0200, Uli Luckas wrote:
> > > On Tuesday, 19. June 2007, Uli Luckas wrote:
> > > > Hi,
> > > > is there anything in the way of apllying this patch?
> > >
> > > Please, can someone tell me what it takes to get a jffs2 bug fix into the
> > > kernel? Or even reviewed? This patch should even get into 2.6.22. Am I
> > > doing something wrong here?
> >
> > You aren't doing anything wrong. David is away on business.
> >
> does that mean, we won't get any fixes applied, before David is back? And does
> anyone know, when he will be back?

Basically, yes. He's the one with the permissions to commit to the mtd
git tree.

> > The one thing I would hesitate with about your patch is that you've now
> > broken the existing behavior of the thread in regards to SIGHUP. You
> > used to be able to send the threads a SIGHUP and it would do a single
> > pass. With your patch, it won't do that unless the thresholds are
> > right. Being able to send SIGHUP to force a GC pass is a pretty useful
> > thing for debugging, etc.
> >
> thanks Josh, alot for reviewing the patch. Following your advise, I force GC
> now, if SIGHUP was received.
> The patch still introduces a change in sematics though for all other signals
> (except SIGKILL). But I feel, the new behavior is more what one would expect.
> In case, the old behavior is desired, it is simple enough to set force_gc in
> the coresponding branches.

Your updated patch looks good to me. Will need a Signed-off-by: line
though.

josh