Re: [PATCH][update] jffs2_gcd_mtd3, Stopping kernel threads timed out

Uli Luckas
2007-06-27T07:54:13Z

On Tuesday, 26. June 2007, Josh Boyer wrote:
> On Tue, 2007-06-26 at 16:39 +0200, Uli Luckas wrote:
> > On Tuesday, 26. June 2007, Josh Boyer wrote:
> > > The one thing I would hesitate with about your patch is that you've now
> > > broken the existing behavior of the thread in regards to SIGHUP. You
> > > used to be able to send the threads a SIGHUP and it would do a single
> > > pass. With your patch, it won't do that unless the thresholds are
> > > right. Being able to send SIGHUP to force a GC pass is a pretty useful
> > > thing for debugging, etc.
> > >
> > thanks Josh, alot for reviewing the patch. Following your advise, I force GC
> > now, if SIGHUP was received.
> > The patch still introduces a change in sematics though for all other signals
> > (except SIGKILL). But I feel, the new behavior is more what one would expect.
> > In case, the old behavior is desired, it is simple enough to set force_gc in
> > the coresponding branches.
>
> Your updated patch looks good to me. Will need a Signed-off-by: line
> though.
>
It's there, right above the patch.