Re: [PATCH] jffs2_gcd_mtd3, Stopping kernel threads timed out

David Woodhouse
2007-06-28T18:52:01Z

On Thu, 2007-06-14 at 15:09 +0200, Uli Luckas wrote:
> The problem seems to happen, when suspend kicks in, after the call to
> try_to_freeze and before the while loop in jffs2_garbage_collect_thread.
>
> The pending freeze will cause signal_pending to return true until the
> attempted suspend is over and thereby the while loop won't terminate until
> the suspend times out.
>
> This patch will call try_to_freeze from within the while loop and adds an
> extra check for jffs2_thread_should_wake before we actually do the GC to
> avoid calling jffs2_garbage_collect_pass at every wakeup.

Thanks. I've committed a slightly simpler fix:
http://git.infradead.org/?p=mtd-2.6.git;a=commitdiff;h=e716dd3644c2a79d6ffa4359bac06f57479dcb34

--
dwmw2