public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Alexander Schmidt <alexs@linux.vnet.ibm.com>
To: linux-mtd@lists.infradead.org, haver@ipnet.vnet.ibm.com
Cc: Andreas Arnez <arnez@linux.vnet.ibm.com>
Subject: Re: [RFC/PATCH] Ubi-Utils: add compare feature
Date: Tue, 10 Jul 2007 12:14:50 +0200	[thread overview]
Message-ID: <200707101214.50385.alexs@linux.vnet.ibm.com> (raw)
In-Reply-To: <1184050337.5944.2.camel@august>

Hi Frank,

> > +#define COMPARE_BUFFER_SIZE 1024
> 
> I think using the something like 2KiB or even the 128KiB would be nicer.

I've played around with several buffer sizes (1KiB, 2KiB, 4KiB and
128KiB), and to my surprise, there was no performance impact.
I've used a 11MiB pfi file and the comparison always takes 5.5 seconds.
But I will change the value to 2KiB, it at least looks nicer.
 
> > +
> >  static const char copyright [] __unused =
> >         "Copyright (c) International Business Machines Corp., 2006";
> 2007

Done.

Thanks for taking a look.
Alex 

  reply	other threads:[~2007-07-10 10:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-09 19:32 [RFC/PATCH] Ubi-Utils: add compare feature Alexander Schmidt
2007-07-10  6:52 ` Frank Haverkamp
2007-07-10 10:14   ` Alexander Schmidt [this message]
2007-07-10 12:52   ` Josh Boyer
2007-07-10 15:41     ` Alexander Schmidt
2007-07-10  7:09 ` Artem Bityutskiy
2007-07-10 10:20   ` Alexander Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200707101214.50385.alexs@linux.vnet.ibm.com \
    --to=alexs@linux.vnet.ibm.com \
    --cc=arnez@linux.vnet.ibm.com \
    --cc=haver@ipnet.vnet.ibm.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox