[PATCH][MTD] Add COMPATIBLE_IOCTL() for MEMGETOOBSEL

[PATCH][MTD] Add COMPATIBLE_IOCTL() for MEMGETOOBSEL

[Mark A. Greer]

The flash_eraseall MTD utility uses the MEMGETOOBSEL so add a
COMPATIBLE_IOCTL() entry for it.

Signed-off-by: Mark A. Greer <mgreer@mvista.com>
---
I know MEMGETOOBSEL is supposed to be obsolete but flash_eraseall uses
it so...

Also, MEMSETOOBSEL is used by nandwrite.c but that ioctl doesn't appear
to be implemented so I didn't add it.  My util source is
http://ftp.linux.org.uk/pub/people/dwmw2/mtd/cvs/mtd/util/
in case I'm looking at old source.

 include/linux/compat_ioctl.h |    1 +
 1 file changed, 1 insertion(+)


diff --git a/include/linux/compat_ioctl.h b/include/linux/compat_ioctl.h
index c26c3ad..3f7d6ab 100644
--- a/include/linux/compat_ioctl.h
+++ b/include/linux/compat_ioctl.h
@@ -694,6 +694,7 @@ COMPATIBLE_IOCTL(MEMLOCK)
 COMPATIBLE_IOCTL(MEMUNLOCK)
 COMPATIBLE_IOCTL(MEMGETREGIONCOUNT)
 COMPATIBLE_IOCTL(MEMGETREGIONINFO)
+COMPATIBLE_IOCTL(MEMGETOOBSEL)
 COMPATIBLE_IOCTL(MEMGETBADBLOCK)
 COMPATIBLE_IOCTL(MEMSETBADBLOCK)
 /* NBD */

Re: [PATCH][MTD] Add COMPATIBLE_IOCTL() for MEMGETOOBSEL

[Josh Boyer]

On 6/20/07, Mark A. Greer <mgreer@mvista.com> wrote:
> The flash_eraseall MTD utility uses the MEMGETOOBSEL so add a
> COMPATIBLE_IOCTL() entry for it.
>
> Signed-off-by: Mark A. Greer <mgreer@mvista.com>
> ---
> I know MEMGETOOBSEL is supposed to be obsolete but flash_eraseall uses
> it so...
>
> Also, MEMSETOOBSEL is used by nandwrite.c but that ioctl doesn't appear
> to be implemented so I didn't add it.  My util source is
> http://ftp.linux.org.uk/pub/people/dwmw2/mtd/cvs/mtd/util/
> in case I'm looking at old source.

You are.  But it's still the same in the current code:

http://git.infradead.org/?p=mtd-utils.git;a=summary

And now that you've found MEMSETOOBSEL being used but not implemented,
I'll have to go figure out what that's about.

Curse you Mark!  ;)

josh

Re: [PATCH][MTD] Add COMPATIBLE_IOCTL() for MEMGETOOBSEL

[Deepak Saxena]

On Jun 20 2007, at 20:52, Josh Boyer was caught saying:
> On 6/20/07, Mark A. Greer <mgreer@mvista.com> wrote:
> > The flash_eraseall MTD utility uses the MEMGETOOBSEL so add a
> > COMPATIBLE_IOCTL() entry for it.
> >
> > Signed-off-by: Mark A. Greer <mgreer@mvista.com>
> > ---
> > I know MEMGETOOBSEL is supposed to be obsolete but flash_eraseall uses
> > it so...
> >
> > Also, MEMSETOOBSEL is used by nandwrite.c but that ioctl doesn't appear
> > to be implemented so I didn't add it.  My util source is
> > http://ftp.linux.org.uk/pub/people/dwmw2/mtd/cvs/mtd/util/
> > in case I'm looking at old source.
> 
> You are.  But it's still the same in the current code:
> 
> http://git.infradead.org/?p=mtd-utils.git;a=summary
> 
> And now that you've found MEMSETOOBSEL being used but not implemented,
> I'll have to go figure out what that's about.

Josh,

I'm merging Mark's patch into the MontaVista tree and will send out and
updated patch vs upstream but also wondering what the proper route is for
MEMSETOOBSEL? I've been out of the mtd loop for a while but looking at the 
git log for mtd-abi.h and mtdchar.c, it looks like the ioctl() was removed 
over a year ago (commit ff268fb8791cf18df536113355d7184007c269d9).  Do we 
re-introduce it or can we update the tools?

Thomas, I'm including you b/c you made the original commit to remove 
MEMSETOOBSEL but also made changes to nandwrite.c that use it a month 
later. :) Should we put MEMSETOOBSEL back in?

Tnx,
~Deepak

-- 
Deepak Saxena - dsaxena@plexity.net - http://www.plexity.net 

"Ever bigger machines, entailing ever bigger concentrations of economic
power and exerting ever greater violence against the environment, do not
represent progress: they are a denial of wisdom. Wisdom demands a new
orientation of science and technology towards the organic, the gentle, the
non-violent, the elegant and beautiful." - Small is Beautiful

Re: [PATCH][MTD] Add COMPATIBLE_IOCTL() for MEMGETOOBSEL

[Josh Boyer]

On 7/13/07, Deepak Saxena <dsaxena@plexity.net> wrote:

> I'm merging Mark's patch into the MontaVista tree and will send out and
> updated patch vs upstream but also wondering what the proper route is for
> MEMSETOOBSEL? I've been out of the mtd loop for a while but looking at the
> git log for mtd-abi.h and mtdchar.c, it looks like the ioctl() was removed
> over a year ago (commit ff268fb8791cf18df536113355d7184007c269d9).  Do we
> re-introduce it or can we update the tools?

I'd prefer to update the tools.  The problem is, I haven't found time
to really look at it yet and I'm not sure _how_ to update it.

> Thomas, I'm including you b/c you made the original commit to remove
> MEMSETOOBSEL but also made changes to nandwrite.c that use it a month
> later. :) Should we put MEMSETOOBSEL back in?

Yeah... Thomas?

josh