public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: akpm@osdl.org, LKML <linux-kernel@vger.kernel.org>,
	kirk@hpc.ee.ntu.edu.tw, linux-mtd@lists.infradead.org,
	WANG Cong <xiyou.wangcong@gmail.com>
Subject: Re: [Resend][Patch] drivers/mtd/maps/tqm8xxl.c: Do some cleanups
Date: Fri, 13 Jul 2007 15:24:43 +0100	[thread overview]
Message-ID: <20070713142442.GA8190@linux-mips.org> (raw)
In-Reply-To: <1184333884.8809.5.camel@hades.cambridge.redhat.com>

On Fri, Jul 13, 2007 at 02:38:03PM +0100, David Woodhouse wrote:

> > drivers/mtd/maps/pmcmsp-flash.c:63: error: 'ELB_1PC_EN_REG' undeclared (first use in this function)
> > drivers/mtd/maps/pmcmsp-flash.c:63: error: 'SINGLE_PCCARD' undeclared (first use in this function)
> > 
> > Did I miss something?
> 
> I think that map driver should probably depend on CONFIG_PMC_MSP. Ralf?

*confused*

68aa0fa87f6d4b2f5e8ad39ecaec8bba9137bb3d did add:

+config MTD_PMC_MSP_EVM
+       tristate "CFI Flash device mapped on PMC-Sierra MSP"
+       depends on PMC_MSP && MTD_CFI
+       select MTD_PARTITIONS

drivers/mtd/maps/Makefile:obj-$(CONFIG_MTD_PMC_MSP_EVM)   += pmcmsp-flash.o

Is he trying to build something else than very recent kernel.org tree?

  Ralf

  reply	other threads:[~2007-07-13 14:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-12 15:01 [Patch] drivers/mtd/maps/tqm8xxl.c: Style cleanups WANG Cong
2007-07-12 16:11 ` Josh Boyer
     [not found]   ` <20070713034822.GA2370@localhost.localdomain>
2007-07-13  9:56     ` [Resend][Patch] drivers/mtd/maps/tqm8xxl.c: Do some cleanups David Woodhouse
2007-07-13 13:14       ` WANG Cong
2007-07-13 13:38         ` David Woodhouse
2007-07-13 14:24           ` Ralf Baechle [this message]
2007-07-13 14:31             ` David Woodhouse
2007-07-13 15:11               ` WANG Cong
2007-07-13 15:05             ` WANG Cong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070713142442.GA8190@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=akpm@osdl.org \
    --cc=dwmw2@infradead.org \
    --cc=kirk@hpc.ee.ntu.edu.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox