Re: [Patch 05/18] fs/logfs/dir.c

["Jörn Engel" <joern@logfs.org>]

On Wed, 8 August 2007 20:07:34 +0300, Artem Bityutskiy wrote:
> On Wed, 2007-08-08 at 18:16 +0200, Jörn Engel wrote:
> > +static inline void logfs_inc_count(struct inode *inode)
> > +{
> > +	inode->i_nlink++;
> > +	mark_inode_dirty_sync(inode);
> > +}
> > +
> > +static inline void logfs_dec_count(struct inode *inode)
> > +{
> > +	inode->i_nlink--;
> > +	mark_inode_dirty_sync(inode);
> > +}
> include/linux/fs.h: inode_inc_link_count() inode_dec_link_count() do
> this. Although not sure they exist in the old kernel your patches are
> against.

Almost, they call mark_inode_dirty() instead of mark_inode_dirty_sync().
I wonder if that's necessary.

Jörn

-- 
Measure. Don't tune for speed until you've measured, and even then
don't unless one part of the code overwhelms the rest.
-- Rob Pike