From: Andrew Morton <akpm@linux-foundation.org>
To: "Mike Frysinger" <vapier.adi@gmail.com>
Cc: bryan.wu@analog.com, linux-mtd@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Blackfin BF54x NAND Flash Controller driver
Date: Thu, 13 Sep 2007 01:49:55 -0700 [thread overview]
Message-ID: <20070913014955.91f4602e.akpm@linux-foundation.org> (raw)
In-Reply-To: <8bd0f97a0709130145u474ab017ocf58b004c5d69dc0@mail.gmail.com>
On Thu, 13 Sep 2007 04:45:13 -0400 "Mike Frysinger" <vapier.adi@gmail.com> wrote:
> On 9/13/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> > On Mon, 03 Sep 2007 15:25:23 +0800 Bryan Wu <bryan.wu@analog.com> wrote:
> > > This is the driver for latest Blackfin BF54x nand flash controller
> > >
> > > - use nand_chip and mtd_info common nand driver interface
> > > - provide both PIO and dma operation
> > > - compiled with ezkit bf548 configuration
> > > - use hardware 1-bit ECC
> > > - tested with YAFFS2 and can mount YAFFS2 filesystem as rootfs
> > >
> > > ...
> > >
> > > +int hardware_ecc = 0;
> >
> > scripts/checkpatch.pl, please.
>
> that isnt static so checkpatch.pl wouldnt have caught it ...
box:/usr/src/25> perl scripts/checkpatch.pl ~/x
ERROR: do not initialise externals to 0 or NULL
#186: FILE: drivers/mtd/nand/bf54x_nand.c:73:
+int hardware_ecc = 0;
> it should be static though of course
good point.
> and then checkpatch.pl would have thrown a
> static init 0 warning :)
> -mike
next prev parent reply other threads:[~2007-09-13 8:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-03 7:25 [PATCH] Blackfin BF54x NAND Flash Controller driver Bryan Wu
2007-09-03 10:14 ` Clemens Koller
2007-09-03 17:58 ` Mike Frysinger
2007-09-03 16:46 ` David Woodhouse
2007-09-03 17:33 ` Bryan Wu
2007-09-03 17:57 ` Mike Frysinger
2007-09-04 3:21 ` Bryan Wu
2007-09-13 8:37 ` Andrew Morton
2007-09-13 8:45 ` Mike Frysinger
2007-09-13 8:45 ` Bryan Wu
2007-09-13 8:51 ` Mike Frysinger
2007-09-13 8:49 ` Bryan Wu
2007-09-13 8:49 ` Andrew Morton [this message]
2007-09-14 7:19 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070913014955.91f4602e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=tglx@linutronix.de \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox