From: "Jörn Engel" <joern@logfs.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "David Woodhouse" <dwmw2@infradead.org>,
"Jörn Engel" <joern@logfs.org>, "Matt Reimer" <mreimer@vpop.net>,
linux-mtd@lists.infradead.org, mattjreimer@gmail.com
Subject: Re: [PATCH] Replace -1 with -EBADMSG in nand error correction code
Date: Sun, 21 Oct 2007 10:42:02 +0200 [thread overview]
Message-ID: <20071021084201.GA5052@lazybastard.org> (raw)
In-Reply-To: <alpine.LFD.0.9999.0710211007080.22770@localhost.localdomain>
On Sun, 21 October 2007 10:08:40 +0200, Thomas Gleixner wrote:
> On Sat, 20 Oct 2007, Jörn Engel wrote:
>
> > Magic numerical values are just bad style. Particularly so when
> > undocumented.
>
> Please resend with a proper Signed-off-by.
> Please add my Acked-by as well.
Already resent privately to dwmw2 (just added a Signed-Off-By: didn't
seem to justify a huge Cc: list). He merged it.
Jörn
--
Eighty percent of success is showing up.
-- Woody Allen
next prev parent reply other threads:[~2007-10-21 10:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 21:33 [PATCH] MTD: treat any negative return value from correct() as an error mattjreimer
2007-10-20 10:42 ` Jörn Engel
2007-10-20 11:11 ` [PATCH] BUG() when passing illegal parameters to decode_rs8() or decode_rs16() Jörn Engel
2007-10-20 11:13 ` [PATCH] Replace -1 with -EBADMSG in nand error correction code Jörn Engel
2007-10-21 8:08 ` Thomas Gleixner
2007-10-21 8:42 ` Jörn Engel [this message]
2007-10-21 8:04 ` [PATCH] BUG() when passing illegal parameters to decode_rs8() or decode_rs16() Thomas Gleixner
2007-10-21 8:06 ` Thomas Gleixner
2007-10-21 8:48 ` Jörn Engel
2007-10-20 16:37 ` [PATCH] MTD: treat any negative return value from correct() as an error Matt Reimer
2007-10-20 17:40 ` Jörn Engel
2007-10-20 17:59 ` Matthew Reimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071021084201.GA5052@lazybastard.org \
--to=joern@logfs.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mattjreimer@gmail.com \
--cc=mreimer@vpop.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox