From: Nick Piggin <nickpiggin@yahoo.com.au>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Erez Zadok <ezk@cs.sunysb.edu>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
jffs-dev@axis.com
Subject: Re: BUG at mm/filemap.c:1749 (2.6.24, jffs2, unionfs)
Date: Sun, 21 Oct 2007 19:57:11 +1000 [thread overview]
Message-ID: <200710211957.11928.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <1192956944.2672.6.camel@shinybook.infradead.org>
On Sunday 21 October 2007 18:55, David Woodhouse wrote:
> On Fri, 2007-10-19 at 17:16 +1000, Nick Piggin wrote:
> > if (writtenlen) {
> > - if (inode->i_size < (pg->index << PAGE_CACHE_SHIFT) +
> > start + writtenlen) { - inode->i_size = (pg->index
> > << PAGE_CACHE_SHIFT) + start + writtenlen; + if
> > (inode->i_size < pos + start + writtenlen) {
> > + inode->i_size = pos + start + writtenlen;
>
> This part seems wrong. Shouldn't it just be pos + writtenlen -- which is
> basically what it was already: pos==(pg->index<<PAGE_CACHE_SHIFT)+start
Yeah you're right, thanks.
prev parent reply other threads:[~2007-10-21 10:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 6:05 BUG at mm/filemap.c:1749 (2.6.24, jffs2, unionfs) Erez Zadok
2007-10-19 7:03 ` Nick Piggin
2007-10-19 7:16 ` Nick Piggin
2007-10-19 17:38 ` Erez Zadok
2007-10-20 13:16 ` David Woodhouse
2007-10-21 8:55 ` David Woodhouse
2007-10-21 9:57 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710211957.11928.nickpiggin@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=dwmw2@infradead.org \
--cc=ezk@cs.sunysb.edu \
--cc=jffs-dev@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox