Re: Some news for this: [PATCH] [MTD] BLOCK_RO: Readonly Block Device Layer Over MTD ?

Gregory CLEMENT
2007-11-23T15:06:11Z

2007/11/23, Jörn Engel <joern@logfs.org>:
> On Fri, 23 November 2007 15:35:17 +0100, Gregory CLEMENT wrote:
> >
> > As it seems that there is no objections on it, can you push the patch in mtd ?
>
> I do object against your patch on formal grounds. It lacks:
> o a useful description,
> o Signed-off-by:,
> o diffstat,
> o diff -up (you just had -u),
> and maybe some more.

In fact this patch was not aimed to be directly included in mtd, but
just to help Vitaly to generate his patch as he offered to generate it
with git. It also seems that he know this patch pretty well and he
could make a better description than me!

>
> Also please fix your mailer so it doesn't word-wrap the patch. I won't
> read it in its current state.

I hopped that google mail was more patch friendly, I was wrong. So I
can't send it inline before tonight at home, but if you don't mind I
can attach it.

>
> You might want to start reading Documentation/Submit* about now. ;)

>
> Jörn
>
> --
> Don't worry about people stealing your ideas. If your ideas are any good,
> you'll have to ram them down people's throats.
> -- Howard Aiken quoted by Ken Iverson quoted by Jim Horning quoted by
> Raph Levien, 1979
>

--
Gregory CLEMENT
Adeneo
Adetel Group
2, chemin du Ruisseau
69134 ECULLY - FRANCE
Tél. : +33 (0)4 72 18 08 40 - Fax : +33 (0)4 72 18 08 41