From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lazybastard.de ([212.112.238.170] helo=longford.lazybastard.org) by bombadil.infradead.org with esmtps (Exim 4.68 #1 (Red Hat Linux)) id 1IzDBi-0004BW-6J for linux-mtd@lists.infradead.org; Mon, 03 Dec 2007 15:26:32 +0000 Date: Mon, 3 Dec 2007 16:20:53 +0100 From: =?utf-8?B?SsO2cm4=?= Engel To: Matt Reimer Subject: Re: [PATCH] MTD: fix s3c2410 error correction Message-ID: <20071203152049.GA15000@lazybastard.org> References: <1192755764-26269-1-git-send-email-mattjreimer@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Cc: linux-mtd@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 29 November 2007 11:10:41 -0800, Matt Reimer wrote: > On Oct 18, 2007 5:02 PM, Matt Reimer wrote: > > From: Matt Reimer > > > > The single-bit error correction was, well, incorrect. For determing which > > bit to correct it was using P1' P2' P4' P8' instead of P1 P2 P4 P8, and > > it was using P16' P32' P64' P128' P256' P512' P1024' P2048' instead of > > P16 P32 P64 P128 P256 P512 P1024 P2048. > > Is there any chance of this getting committed? It has been confirmed > to be needed on s3c2440 and s3c2412. Ok, I'm getting sick of this. Even though I didn't fully review the patch, I'll gladly take the chances of breaking something and complaining to Matt afterwards. Certainly beats ignoring this patch for all eternity. Acked-by: Joern Engel Jörn -- You ain't got no problem, Jules. I'm on the motherfucker. Go back in there, chill them niggers out and wait for the Wolf, who should be coming directly. -- Marsellus Wallace