public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: "Jörn Engel" <joern@logfs.org>
To: Artem Bityutskiy <dedekind@infradead.org>
Cc: joern@logfs.org, linux-mtd@lists.infradead.org,
	Alexey Korolev <akorolev@infradead.org>
Subject: Re: [RFC][patch] NAND partial page read functionality
Date: Tue, 18 Dec 2007 12:42:33 +0100	[thread overview]
Message-ID: <20071218114232.GA1741@lazybastard.org> (raw)
In-Reply-To: <1197967731.18962.25.camel@sauron>

On Tue, 18 December 2007 10:48:51 +0200, Artem Bityutskiy wrote:
> 
> Well, this depends. If an MTD user wants to write 4KiB, and issues 4KiB
> write request, then it is of course faster to write 2x2048, then 8x512,
> and it is even faster to do some kind of multi-page write (some old
> flashes had this AFAIK).

Not necessarily.  The alauda chip has a "page program" and a "block
program" command.  With a naive implementation the block program is
faster.  But when doing asynchronous transfers on the usb bus, page
program becomes just as fast.  In this particular case, block program
can only reduce the number of synchronous bus latencies for a
non-optimized implementation.

> But surely if the driver is not dumb, it will do 2x2048?
> 
> I've glanced at jffs2_flash_writev(), and it seems it is also not dumb -
> if in needs to write a 4KiB buffer, it first finishes current
> write-buffer, flushes it, then it calles mtd->write() for multiple min.
> I/O units (note, it does not use wbuf now), and only the rest, which
> does not comprise whole min. I/O unit, goes to the wbuf.
> 
> Thus, I'd conclude, JFFS2 should benefit.

If writesize is 256 and pagesize is 2048, every wbuf flush will write
exactly 256.  Any remaining clean multiple of 256 is written directly,
but this will rarely be an aligned clean multiple of 2048.  Every wbuf
flush ensures that either the previous or the following writes is not.

As long as JFFS2 and MTD are synchronous, this could be a significant
performance hit.

Jörn

-- 
Mac is for working,
Linux is for Networking,
Windows is for Solitaire!
-- stolen from dc

  reply	other threads:[~2007-12-18 13:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-13 18:15 [RFC][patch] NAND partial page read functionality Alexey Korolev
2007-12-15 12:13 ` Artem Bityutskiy
2007-12-17 15:46   ` Alexey Korolev
2007-12-18  8:48     ` Artem Bityutskiy
2007-12-18 11:42       ` Jörn Engel [this message]
2007-12-18 12:57         ` Artem Bityutskiy
2007-12-18 13:51           ` Jörn Engel
2008-04-24  6:34 ` Artem Bityutskiy
2008-04-24  7:11   ` Artem Bityutskiy
2008-04-24  7:45   ` Hamish Moffatt
2008-04-24  9:53     ` Artem Bityutskiy
2008-04-24 10:25     ` Alexey Korolev
2008-04-24 10:45       ` Artem Bityutskiy
2008-04-24 10:57         ` Alexey Korolev
2008-04-24 14:04       ` Hamish Moffatt
2008-04-24 14:48         ` Alexey Korolev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071218114232.GA1741@lazybastard.org \
    --to=joern@logfs.org \
    --cc=akorolev@infradead.org \
    --cc=dedekind@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox