Re: [PATCH] [MTD] [RFC] New Solarflare NIC EEPROM/Flash driver (2nd try)

Ben Hutchings
2008-01-15T18:00:40Z

Something I missed:

Jörn Engel wrote:
<snip>
> You can replace EFX_ASSERT with BUG_ON (with negated condition)
> throughout the code. Duplicating existing kernel infrastructure needs a
> very good reason to be accepted.
<snip>

Assertions made with EFX_ASSERT() are only checked if EFX_ENABLE_DEBUG
is set, and we don't really want them to be included in a production
build. Is there a suitable kernel facility for more paranoid checks
that will be disabled by default?

Ben.

--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.