Re: [PATCH] [MTD] [RFC] New Solarflare NIC EEPROM/Flash driver (2nd try)

Jörn Engel
2008-01-15T18:37:48Z

On Tue, 15 January 2008 17:57:32 +0000, Ben Hutchings wrote:
> Jörn Engel wrote:
> <snip>
> > You can replace EFX_ASSERT with BUG_ON (with negated condition)
> > throughout the code. Duplicating existing kernel infrastructure needs a
> > very good reason to be accepted.
> <snip>
>
> Assertions made with EFX_ASSERT() are only checked if EFX_ENABLE_DEBUG
> is set, and we don't really want them to be included in a production
> build. Is there a suitable kernel facility for more paranoid checks
> that will be disabled by default?

Not that I know of. Having this once in a generic form might be useful.

Jörn

--
I've never met a human being who would want to read 17,000 pages of
documentation, and if there was, I'd kill him to get him out of the
gene pool.
-- Joseph Costello