From: Ben Hutchings <bhutchings@solarflare.com>
To: "Jörn Engel" <joern@logfs.org>
Cc: linux-net-drivers@solarflare.com, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [MTD] [RFC] New Solarflare NIC EEPROM/Flash driver (2nd try)
Date: Tue, 15 Jan 2008 17:57:32 +0000 [thread overview]
Message-ID: <20080115175731.GF28547@solarflare.com> (raw)
In-Reply-To: <20080115164613.GC22338@lazybastard.org>
Something I missed:
Jörn Engel wrote:
<snip>
> You can replace EFX_ASSERT with BUG_ON (with negated condition)
> throughout the code. Duplicating existing kernel infrastructure needs a
> very good reason to be accepted.
<snip>
Assertions made with EFX_ASSERT() are only checked if EFX_ENABLE_DEBUG
is set, and we don't really want them to be included in a production
build. Is there a suitable kernel facility for more paranoid checks
that will be disabled by default?
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
next prev parent reply other threads:[~2008-01-15 18:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-10 18:51 [PATCH] [MTD] [RFC] New Solarflare NIC EEPROM/Flash driver Robert Stonehouse
2008-01-10 20:13 ` Jörn Engel
2008-01-10 23:16 ` Jörn Engel
2008-01-11 12:50 ` Ben Hutchings
2008-01-11 13:24 ` Jörn Engel
2008-01-11 18:55 ` Ben Hutchings
2008-01-11 19:57 ` Jörn Engel
2008-01-13 17:19 ` David Riddoch
2008-01-14 17:04 ` [PATCH] [MTD] [RFC] New Solarflare NIC EEPROM/Flash driver (2nd try) Ben Hutchings
2008-01-15 16:46 ` Jörn Engel
2008-01-15 17:35 ` Ben Hutchings
2008-01-15 17:55 ` Jörn Engel
2008-01-15 17:57 ` Ben Hutchings [this message]
2008-01-15 18:28 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080115175731.GF28547@solarflare.com \
--to=bhutchings@solarflare.com \
--cc=joern@logfs.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-net-drivers@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox