From: "Jörn Engel" <joern@logfs.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: Andrew Victor <andrew@sanpeople.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org,
Frank Mandarino <fmandarino@endrelia.com>
Subject: Re: [PATCH] at91_nand: Make part_probes[] static
Date: Wed, 30 Jan 2008 00:17:43 +0100 [thread overview]
Message-ID: <20080129231743.GD32157@lazybastard.org> (raw)
In-Reply-To: <20080129.222837.126141133.anemo@mba.ocn.ne.jp>
On Tue, 29 January 2008 22:28:37 +0900, Atsushi Nemoto wrote:
>
> This patch fixes this sparse warning:
>
> linux/drivers/mtd/nand/at91_nand.c:86:12: warning: symbol 'part_probes' was not declared. Should it be static?
You cannot fix a warning. You can only fix code. Warnings can be and
often are wrong. This particular is right, so in spite of the
description
Acked-by: Joern Engel <joern@logfs.org>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> diff --git a/drivers/mtd/nand/at91_nand.c b/drivers/mtd/nand/at91_nand.c
> index b2a5672..9adbf2a 100644
> --- a/drivers/mtd/nand/at91_nand.c
> +++ b/drivers/mtd/nand/at91_nand.c
> @@ -83,7 +83,7 @@ static void at91_nand_disable(struct at91_nand_host *host)
> }
>
> #ifdef CONFIG_MTD_PARTITIONS
> -const char *part_probes[] = { "cmdlinepart", NULL };
> +static const char *part_probes[] = { "cmdlinepart", NULL };
> #endif
>
> /*
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
Jörn
--
Joern's library part 11:
http://www.unicom.com/pw/reply-to-harmful.html
next prev parent reply other threads:[~2008-01-30 0:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 13:28 [PATCH] at91_nand: Make part_probes[] static Atsushi Nemoto
2008-01-29 23:17 ` Jörn Engel [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-03-30 12:59 Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080129231743.GD32157@lazybastard.org \
--to=joern@logfs.org \
--cc=andrew@sanpeople.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=dwmw2@infradead.org \
--cc=fmandarino@endrelia.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox