* [PATCH] at91_nand: Make part_probes[] static
@ 2008-01-29 13:28 Atsushi Nemoto
2008-01-29 23:17 ` Jörn Engel
0 siblings, 1 reply; 3+ messages in thread
From: Atsushi Nemoto @ 2008-01-29 13:28 UTC (permalink / raw)
To: Andrew Victor; +Cc: David Woodhouse, linux-mtd, Frank Mandarino
This patch fixes this sparse warning:
linux/drivers/mtd/nand/at91_nand.c:86:12: warning: symbol 'part_probes' was not declared. Should it be static?
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/drivers/mtd/nand/at91_nand.c b/drivers/mtd/nand/at91_nand.c
index b2a5672..9adbf2a 100644
--- a/drivers/mtd/nand/at91_nand.c
+++ b/drivers/mtd/nand/at91_nand.c
@@ -83,7 +83,7 @@ static void at91_nand_disable(struct at91_nand_host *host)
}
#ifdef CONFIG_MTD_PARTITIONS
-const char *part_probes[] = { "cmdlinepart", NULL };
+static const char *part_probes[] = { "cmdlinepart", NULL };
#endif
/*
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] at91_nand: Make part_probes[] static
2008-01-29 13:28 [PATCH] at91_nand: Make part_probes[] static Atsushi Nemoto
@ 2008-01-29 23:17 ` Jörn Engel
0 siblings, 0 replies; 3+ messages in thread
From: Jörn Engel @ 2008-01-29 23:17 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: Andrew Victor, David Woodhouse, linux-mtd, Frank Mandarino
On Tue, 29 January 2008 22:28:37 +0900, Atsushi Nemoto wrote:
>
> This patch fixes this sparse warning:
>
> linux/drivers/mtd/nand/at91_nand.c:86:12: warning: symbol 'part_probes' was not declared. Should it be static?
You cannot fix a warning. You can only fix code. Warnings can be and
often are wrong. This particular is right, so in spite of the
description
Acked-by: Joern Engel <joern@logfs.org>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> diff --git a/drivers/mtd/nand/at91_nand.c b/drivers/mtd/nand/at91_nand.c
> index b2a5672..9adbf2a 100644
> --- a/drivers/mtd/nand/at91_nand.c
> +++ b/drivers/mtd/nand/at91_nand.c
> @@ -83,7 +83,7 @@ static void at91_nand_disable(struct at91_nand_host *host)
> }
>
> #ifdef CONFIG_MTD_PARTITIONS
> -const char *part_probes[] = { "cmdlinepart", NULL };
> +static const char *part_probes[] = { "cmdlinepart", NULL };
> #endif
>
> /*
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
Jörn
--
Joern's library part 11:
http://www.unicom.com/pw/reply-to-harmful.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] at91_nand: Make part_probes[] static
@ 2008-03-30 12:59 Atsushi Nemoto
0 siblings, 0 replies; 3+ messages in thread
From: Atsushi Nemoto @ 2008-03-30 12:59 UTC (permalink / raw)
To: Andrew Victor
Cc: linux-mtd, Jörn Engel, David Woodhouse, Frank Mandarino
The part_probes[] should be static.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Acked-by: Joern Engel <joern@logfs.org>
---
This is a resend of same patch, with (hopefully) better description.
diff --git a/drivers/mtd/nand/at91_nand.c b/drivers/mtd/nand/at91_nand.c
index b2a5672..9adbf2a 100644
--- a/drivers/mtd/nand/at91_nand.c
+++ b/drivers/mtd/nand/at91_nand.c
@@ -83,7 +83,7 @@ static void at91_nand_disable(struct at91_nand_host *host)
}
#ifdef CONFIG_MTD_PARTITIONS
-const char *part_probes[] = { "cmdlinepart", NULL };
+static const char *part_probes[] = { "cmdlinepart", NULL };
#endif
/*
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-03-30 12:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-29 13:28 [PATCH] at91_nand: Make part_probes[] static Atsushi Nemoto
2008-01-29 23:17 ` Jörn Engel
-- strict thread matches above, loose matches on Subject: below --
2008-03-30 12:59 Atsushi Nemoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox