Re: [PATCH] physmap-concat map platform driver

Anton Vorontsov
2007-06-07T19:04:48Z

On Thu, Jun 07, 2007 at 02:07:51PM +0200, Lennert Buytenhek wrote:
> On Fri, Jun 01, 2007 at 01:58:38AM +0400, Anton Vorontsov wrote:
>
> > > > This is physmap-concat driver, which is plain sa1100-flash.c
> > > > with factored out arch-specific code. This driver is essential for
> > > > boards using multiple nonindentical chips on the board.
> > >
> > > Doesn't physmap also support multiple nonidentical chips?
> >
> > Nope. E.g. if I have two chips, 32M + 16M, second chip will be visible
> > as 32M, which is wrong.
>
> OK, why is that? Is that easily fixable?

Don't know why, David said it's what expected in such setup, and that's
indeed what I'm observing. I'm unsure that it needs any fixups though.
For now I'm just registering two physmap devices, per each chip.

> > > What physmap doesn't support is multiple discontiguous memory
> > > regions.
> >
> > Yes, this is another disadvantage of current physmap.
> >
> > > Maybe it makes more sense to add that support to physmap
> > > instead?
> >
> > Well.. more easier solution would be merging physmap-concat to physmap,
> > trying make physmap-concat platform_data-compatible.
>
> Hmmm, isn't that more or less what I said? What's the difference?

That's exactly what you've said. I was in hurry and misread your
initial message. Sorry.

> thanks,
> Lennert

Thanks,

--
Anton Vorontsov
email: cbou@mail.ru
backup email: ya-cbou@yandex.ru
irc://irc.freenode.org/bd2