public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2] mtd: Fix physmap_of to not exit upon unsuccessful partition scan
Date: Thu, 14 Feb 2008 16:44:06 +0100	[thread overview]
Message-ID: <200802141644.07115.sr@denx.de> (raw)
In-Reply-To: <87skzvr5eu.fsf@macbook.be.48ers.dk>

On Thursday 14 February 2008, Peter Korsgaard wrote:
> >>>>> "Stefan" == Stefan Roese <sr@denx.de> writes:
>
>  Stefan> The patch 9a310d21196f38f6ad0ad146057548653e495c09 ("[MTD]
>  Stefan> Factor out OF partition support from the NOR driver.")
>  Stefan> introduced an problem. Now the physmap_of driver returns with
>  Stefan> error upon the first unsuccessful partition scan
>  Stefan> (parse_mtd_partitions()). This is not wanted, since even when
>  Stefan> the RedBoot/cmdlinepart partition scan is unsuccessful, the
>  Stefan> other scan's (of_mtd_parse_partitions(),
>  Stefan> parse_obsolete_partitions()) should be done nevertheless.
>
> Doesn't it make more sense to fix the real problem (E.G. cmdlinepart.c
> flagging missing partition info as an error) - See the patch I posted
> earlier today.

Yes, this is probably even better. I just tested it successfully on my board.

Do you plan to post a "real patch" with Signed-off-by? You can add my Acked-by 
too then.

BTW: I would really like to see one of the solutions go into 2.6.25 since it's 
really a bug fix.

Thanks.

Best regards,
Stefan

      reply	other threads:[~2008-02-14 15:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13 11:19 [PATCH v2] mtd: Fix physmap_of to not exit upon unsuccessful partition scan Stefan Roese
2008-02-14 14:14 ` Peter Korsgaard
2008-02-14 15:44   ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802141644.07115.sr@denx.de \
    --to=sr@denx.de \
    --cc=dwmw2@infradead.org \
    --cc=jacmet@sunsite.dk \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox