From: David Brownell <david-b@pacbell.net>
To: Josh Boyer <jwboyer@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
Michael Trimarchi <trimarchimichael@yahoo.it>,
spi-devel-general@lists.sourceforge.net,
Andrew Morton <akpm@linux-foundation.org>,
dwmw2@infradead.org, linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH] jffs2 summary allocation
Date: Fri, 4 Apr 2008 16:58:38 -0700 [thread overview]
Message-ID: <200804041658.38499.david-b@pacbell.net> (raw)
In-Reply-To: <1207351282.3224.79.camel@vader.jdub.homelinux.org>
On Friday 04 April 2008, Josh Boyer wrote:
>
> > ... This means specifically that you may _not_ use the
> > memory/addresses returned from vmalloc() for DMA. ...
> >
> > So I'm rather surprised to see *ANY* kernel code trying to do
> > that. That rule has been in effect for many, many years now.
>
> I don't think it was intentional. You're going through several layers
> here:
>
> JFFS2 -> mtd parts -> mtd dataflash -> atmel_spi.
>
> Typically MTD drivers aren't doing DMAs to flash and JFFS2 has no idea
> which particular chip driver is being used because it's abstracted by
> MTD.
That's true ... although I can imagine using DMA to
avoid dcache trashing if its setup cost is low enough,
with either NAND or NOR chips.
Still: in this context vmalloc() is wrong.
- Dave
next prev parent reply other threads:[~2008-04-04 23:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-04 10:23 [PATCH] jffs2 summary allocation Michael Trimarchi
2008-04-04 19:48 ` Andrew Morton
2008-04-04 20:09 ` Russell King - ARM Linux
2008-04-04 23:09 ` David Brownell
2008-04-04 23:21 ` Josh Boyer
2008-04-04 23:58 ` David Brownell [this message]
2008-04-05 1:11 ` Josh Boyer
2008-04-05 1:29 ` Kyungmin Park
2008-04-05 1:46 ` Andrew Morton
2008-04-05 2:41 ` David Brownell
2008-04-05 3:27 ` Andrew Morton
2008-04-05 2:17 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804041658.38499.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=jwboyer@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=trimarchimichael@yahoo.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox