From: "Jörn Engel" <joern@logfs.org>
To: Justin Treon <justin_treon@yahoo.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [Patch][MTD][NAND] Rodan NAND controller
Date: Mon, 5 May 2008 20:23:00 +0200 [thread overview]
Message-ID: <20080505182300.GA18494@logfs.org> (raw)
In-Reply-To: <567477.3675.qm@web43132.mail.sp1.yahoo.com>
On Fri, 2 May 2008 15:04:39 -0700, Justin Treon wrote:
>
> +const static struct mtd_partition partition_info[] = {
> + {
> + .name = "IMFT NAND",
> + .offset = 0,
> + .size = 256 * 1024 * 1024}
> +};
It took me a third look to find the closing brace.
> + /* Initialize structures */
> + memset((char *)rodan_mtd, 0, sizeof(struct mtd_info));
> + memset((char *)this, 0, sizeof(struct nand_chip));
The casts don't seem necessary.
Otherwise looks fine to me. So module the cosmetics, it is
Acked-By: Joern Engel <joern@logfs.org>
Jörn
--
Do not stop an army on its way home.
-- Sun Tzu
prev parent reply other threads:[~2008-05-05 18:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 22:04 [Patch][MTD][NAND] Rodan NAND controller Justin Treon
2008-05-05 18:23 ` Jörn Engel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080505182300.GA18494@logfs.org \
--to=joern@logfs.org \
--cc=justin_treon@yahoo.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox