public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Hamish Moffatt <hamish@cloud.net.au>
To: "Jörn Engel" <joern@logfs.org>
Cc: linux-mtd@lists.infradead.org, tglx@linutronix.de,
	dwmw2@infradead.org, Alexey Korolev <akorolev@infradead.org>
Subject: Re: [PATCH][RFC] NAND subpage read feature. Take 2.
Date: Tue, 6 May 2008 10:15:15 +1000	[thread overview]
Message-ID: <20080506001514.GA12796@cloud.net.au> (raw)
In-Reply-To: <20080505073745.GA13916@logfs.org>

On Mon, May 05, 2008 at 09:37:45AM +0200, Jörn Engel wrote:
> On Sun, 4 May 2008 12:46:31 +0400, Alexander Belyakov wrote:
> > On Fri, May 2, 2008 at 12:25 AM, Jörn Engel <joern@logfs.org> wrote:
> > >
> > > ...and creates a peculiar conflict of interests in me.  I've added full
> > > caching of the complete mtd in logfs, which gave a huge speedup to some
> > > of my testcases.  However caching is done in page granularity, therefore
> > > it would completely defeat this patch, which also gives a speedup.
> > 
> > There is a special case for page aligned data where generic
> > read_page() is being used instead of read_subpage(). I believe logfs
> > caching won't suffer from this patch.
> 
> Actually, logfs caching would help jffs2 as well, as soon as you have
> several parallel readers.  It should be made generic mtd caching.  And
> when made generic, it would effectively defeat this patch, as all reads
> would be (DRAM-) pagesized.

.. and therefore performance would be worse for UBI attach, for example.
Caching only makes sense when you can read extra data at no cost. Unless
you can find some way to cache while idle but abort if it is delaying
another read?


Hamish
-- 
Hamish Moffatt VK3SB <hamish@debian.org> <hamish@cloud.net.au>

  parent reply	other threads:[~2008-05-06  0:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30 12:13 [PATCH][RFC] NAND subpage read feature. Take 2 Alexey Korolev
2008-05-01  4:40 ` Hamish Moffatt
2008-05-01  5:34   ` MTD PARTITION Aneesh
2008-05-14 17:13   ` [PATCH][RFC] NAND subpage read feature. Take 2 Alexey Korolev
2008-05-01 20:25 ` Jörn Engel
2008-05-04  8:46   ` Alexander Belyakov
2008-05-05  7:37     ` Jörn Engel
2008-05-05 12:10       ` Alexander Belyakov
2008-05-05 15:39         ` Jörn Engel
2008-05-06  9:29           ` Alexander Belyakov
2008-05-08 15:30             ` Jörn Engel
2008-05-08 15:33               ` Artem Bityutskiy
2008-05-08 15:38                 ` Jörn Engel
2008-05-06  0:15       ` Hamish Moffatt [this message]
2008-05-06  6:15         ` Jörn Engel
2008-05-06  9:42           ` Hamish Moffatt
2008-05-06 10:47             ` Jörn Engel
2008-05-14 17:34   ` Alexey Korolev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080506001514.GA12796@cloud.net.au \
    --to=hamish@cloud.net.au \
    --cc=akorolev@infradead.org \
    --cc=dwmw2@infradead.org \
    --cc=joern@logfs.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox