public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Hamish Moffatt <hamish@cloud.net.au>
To: "Jörn Engel" <joern@logfs.org>
Cc: dwmw2@infradead.org, tglx@linutronix.de,
	linux-mtd@lists.infradead.org,
	Alexey Korolev <akorolev@infradead.org>
Subject: Re: [PATCH][RFC] NAND subpage read feature. Take 2.
Date: Tue, 6 May 2008 19:42:49 +1000	[thread overview]
Message-ID: <20080506094249.GA23685@cloud.net.au> (raw)
In-Reply-To: <20080506061530.GA23412@logfs.org>

On Tue, May 06, 2008 at 08:15:31AM +0200, Jörn Engel wrote:
> On Tue, 6 May 2008 10:15:15 +1000, Hamish Moffatt wrote:
> > 
> > Caching only makes sense when you can read extra data at no cost.
> 
> Not true.  Caching makes sense when the benefits outweigh the costs,
> just like everything else.  "No cost" is just a special case where even
> minimal benefits suffice.
> 
> Nand already does caching, it just limits itself to a single page.  If
> two consecutive reads hit the single page, it is only read once.  Which
> easily fits your definition and just as easily helps single-threaded
> users.  But two threads bouncing back and forth can already nullify the
> gains.  It would be useful to keep as much old data around as there is
> DRAM for.

It makes sense to keep data that you had to read anyway, but with the
subpage read patch that's less than a whole page.

> [ Also, even ubi attach may benefit from caching under special
> circumstances.  If you have just written an image and have enough ram,
> there is no reason to go back to flash.  But that hardly matters in real
> life. ]

I agree. So are we talking about caching of data which we've read
anyway, or speculative reads? Because reading more than the user
requested is speculation afaict. If LogFS (for example) reads a whole 
page even when it doesn't need it, that will degrade performance in some
cases.

Hamish
-- 
Hamish Moffatt VK3SB <hamish@debian.org> <hamish@cloud.net.au>

  reply	other threads:[~2008-05-06  9:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30 12:13 [PATCH][RFC] NAND subpage read feature. Take 2 Alexey Korolev
2008-05-01  4:40 ` Hamish Moffatt
2008-05-01  5:34   ` MTD PARTITION Aneesh
2008-05-14 17:13   ` [PATCH][RFC] NAND subpage read feature. Take 2 Alexey Korolev
2008-05-01 20:25 ` Jörn Engel
2008-05-04  8:46   ` Alexander Belyakov
2008-05-05  7:37     ` Jörn Engel
2008-05-05 12:10       ` Alexander Belyakov
2008-05-05 15:39         ` Jörn Engel
2008-05-06  9:29           ` Alexander Belyakov
2008-05-08 15:30             ` Jörn Engel
2008-05-08 15:33               ` Artem Bityutskiy
2008-05-08 15:38                 ` Jörn Engel
2008-05-06  0:15       ` Hamish Moffatt
2008-05-06  6:15         ` Jörn Engel
2008-05-06  9:42           ` Hamish Moffatt [this message]
2008-05-06 10:47             ` Jörn Engel
2008-05-14 17:34   ` Alexey Korolev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080506094249.GA23685@cloud.net.au \
    --to=hamish@cloud.net.au \
    --cc=akorolev@infradead.org \
    --cc=dwmw2@infradead.org \
    --cc=joern@logfs.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox