From: "Jörn Engel" <joern@logfs.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: dwmw2@infradead.org, Bryan Wu <cooloney@kernel.org>,
linux-mtd@lists.infradead.org, will.newton@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] [MTD/MAPS] Blackfin Async Flash Maps: Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank
Date: Tue, 13 May 2008 17:34:42 +0200 [thread overview]
Message-ID: <20080513153441.GB18026@logfs.org> (raw)
In-Reply-To: <8bd0f97a0805130815q2ffa1d34ue87f5eb1422b6f42@mail.gmail.com>
On Tue, 13 May 2008 11:15:57 -0400, Mike Frysinger wrote:
> On Tue, May 13, 2008 at 11:01 AM, Jörn Engel wrote:
> > On Tue, 13 May 2008 08:42:08 -0400, Mike Frysinger wrote:
> > > On Tue, May 13, 2008 at 4:07 AM, Jörn Engel wrote:
> > > > On Tue, 13 May 2008 12:38:45 +0800, Bryan Wu wrote:
> > > > >
> > > > > +#define pr_devinit(fmt, args...) ({ static const __devinitdata char __fmt[] = fmt; printk(__fmt, ## args); })
> > > >
> > > > Is this still needed?
> > >
> > > yes
> >
> > Can you elaborate a bit?
>
> it's still used, therefore the definition cannot be dropped. just
> look at the probe function.
That bit is obvious. But why do you use pr_devinit() instead of
printk()? What does it gain you?
Jörn
--
Das Aufregende am Schreiben ist es, eine Ordnung zu schaffen, wo
vorher keine existiert hat.
-- Doris Lessing
next prev parent reply other threads:[~2008-05-13 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 4:38 [PATCH 1/1] [MTD/MAPS] Blackfin Async Flash Maps: Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank Bryan Wu
2008-05-13 8:07 ` Jörn Engel
2008-05-13 12:42 ` Mike Frysinger
2008-05-13 15:01 ` Jörn Engel
2008-05-13 15:15 ` Mike Frysinger
2008-05-13 15:34 ` Jörn Engel [this message]
2008-05-13 17:42 ` Mike Frysinger
2008-05-13 19:16 ` Jörn Engel
2008-05-14 2:50 ` Bryan Wu
2008-05-13 17:41 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080513153441.GB18026@logfs.org \
--to=joern@logfs.org \
--cc=cooloney@kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier.adi@gmail.com \
--cc=will.newton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox