From: "Jörn Engel" <joern@logfs.org>
To: Alexey Korolev <akorolev@infradead.org>
Cc: dwmw2@infradead.org, tglx@linutronix.de,
linux-mtd@lists.infradead.org, vasiliy.leonenko@gmail.com
Subject: Re: [RFC/PATCH 2/3] NAND multiple plane feature
Date: Thu, 5 Jun 2008 20:58:09 +0200 [thread overview]
Message-ID: <20080605185809.GA19234@logfs.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0806051724560.16300@pentafluge.infradead.org>
On Thu, 5 June 2008 17:58:14 +0100, Alexey Korolev wrote:
>
> > > - if (!chip->write_page)
> > > - chip->write_page = nand_write_page;
> > > -
> >
> > Why is this removed?
> >
> Oh. May be it would be better to make stand alone patch in order to
> clean up NAND subsystem.
Yes, please. :)
> Using chip->write_page is redundend here. It
> is set once it is set for write procedure only. There is no chip read
> page call like that. IMHO it is better to use static call here. Please
> let me know if you are agree with this.
Setting it just once is clearly better. So long as it actually happens
and we don't introduce a bug, I like it.
Jörn
--
When I am working on a problem I never think about beauty. I think
only how to solve the problem. But when I have finished, if the
solution is not beautiful, I know it is wrong.
-- R. Buckminster Fuller
next prev parent reply other threads:[~2008-06-05 18:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-28 13:08 [RFC/PATCH 2/3] NAND multiple plane feature Alexey Korolev
2008-06-01 17:48 ` Jörn Engel
2008-06-02 11:28 ` Jamie Lokier
2008-06-02 11:36 ` Jörn Engel
2008-06-03 16:57 ` Alexey Korolev
2008-06-03 17:20 ` Jörn Engel
2008-06-05 21:09 ` Jörn Engel
2008-06-06 14:01 ` Alexey Korolev
2008-06-06 16:22 ` Jörn Engel
2008-06-03 17:42 ` Jörn Engel
2008-06-05 16:58 ` Alexey Korolev
2008-06-05 18:58 ` Jörn Engel [this message]
2008-06-05 19:13 ` Thomas Gleixner
2008-06-06 10:08 ` Alexey Korolev
2008-06-06 12:16 ` Thomas Gleixner
2008-06-06 13:47 ` Alexey Korolev
2008-06-06 14:19 ` Thomas Gleixner
2008-06-06 14:36 ` Alexey Korolev
2008-06-05 20:03 ` Thomas Gleixner
2008-06-10 17:33 ` Alexey Korolev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080605185809.GA19234@logfs.org \
--to=joern@logfs.org \
--cc=akorolev@infradead.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=tglx@linutronix.de \
--cc=vasiliy.leonenko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox