From: "Jörn Engel" <joern@logfs.org>
To: Jamie Lokier <jamie@shareable.org>
Cc: linux-mtd@lists.infradead.org, Bruce_Leonard@selinc.com
Subject: Re: mtd_info->size again (lengthy)
Date: Tue, 10 Jun 2008 13:46:29 +0200 [thread overview]
Message-ID: <20080610114604.GA31069@logfs.org> (raw)
In-Reply-To: <20080610105647.GD25910@shareable.org>
On Tue, 10 June 2008 11:56:48 +0100, Jamie Lokier wrote:
>
> I just don't see any advantage to assuming "nobody will ever use 4GiB
> erase blocks", when changing the API with larger sizes.
*shrug*
I use u64 for the number of eraseblocks because it doesn't take a lot of
imagination to see u32 overflow before I retire. It didn't take a lot
of imagination to see the u32 size problem coming either. Relying on "a
good reason that I haven't thought of" is a bit of a stretch.
Let me put it this way: if you spend the time and create all the
patches, you can use u128 for all I care.
> I have a particularly crappy one where erase blocks the CPU if the CPU
> reads from the chip during the erase - so the cfi_cmdset_0002.c file
> needs a patch to avoid polling the status register for this board.
> This is topic for another post, though.
Nothing can prevent bad drivers. At least they are easy to fix.
Jörn
--
"Security vulnerabilities are here to stay."
-- Scott Culp, Manager of the Microsoft Security Response Center, 2001
next prev parent reply other threads:[~2008-06-10 11:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 5:38 mtd_info->size again (lengthy) Bruce_Leonard
2008-06-08 12:10 ` Jörn Engel
2008-06-08 12:13 ` Jörn Engel
2008-06-09 2:51 ` Bruce_Leonard
2008-06-09 5:21 ` Jörn Engel
2008-06-09 4:43 ` Bruce_Leonard
2008-06-09 5:28 ` Jörn Engel
2008-06-09 13:21 ` Jamie Lokier
2008-06-09 14:36 ` Jörn Engel
2008-06-09 16:31 ` Jamie Lokier
2008-06-09 17:22 ` Jörn Engel
2008-06-10 10:56 ` Jamie Lokier
2008-06-10 11:46 ` Jörn Engel [this message]
2008-06-11 0:09 ` Bruce_Leonard
2008-06-11 7:18 ` Jörn Engel
2008-06-11 7:46 ` Bruce_Leonard
2008-06-11 9:13 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080610114604.GA31069@logfs.org \
--to=joern@logfs.org \
--cc=Bruce_Leonard@selinc.com \
--cc=jamie@shareable.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox