From: "Jörn Engel" <joern@logfs.org>
To: Robert Jarzmik <rjarzmik@free.fr>
Cc: linux-mtd@lists.infradead.org
Subject: Re: physmap without MTD partitions
Date: Mon, 16 Jun 2008 15:08:10 +0200 [thread overview]
Message-ID: <20080616130810.GA20814@logfs.org> (raw)
In-Reply-To: <87k5gpv9qn.fsf@free.fr>
On Mon, 16 June 2008 14:34:56 +0200, Robert Jarzmik wrote:
>
> Don't call suspend/resume functions if they have not been
> defined.
>
> Signed-off-by: Robert Jarzmik <rjarzmik@free.fr>
Acked-By: Joern Engel <joern@logfs.org>
> ---
> drivers/mtd/maps/physmap.c | 11 +++++++----
> 1 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
> index 183255f..73c770b 100644
> --- a/drivers/mtd/maps/physmap.c
> +++ b/drivers/mtd/maps/physmap.c
> @@ -203,7 +203,8 @@ static int physmap_flash_suspend(struct platform_device *dev, pm_message_t state
> int i;
>
> for (i = 0; i < MAX_RESOURCES && info->mtd[i]; i++)
> - ret |= info->mtd[i]->suspend(info->mtd[i]);
> + if (info->mtd[i]->suspend)
> + ret |= info->mtd[i]->suspend(info->mtd[i]);
>
> return ret;
> }
> @@ -214,7 +215,8 @@ static int physmap_flash_resume(struct platform_device *dev)
> int i;
>
> for (i = 0; i < MAX_RESOURCES && info->mtd[i]; i++)
> - info->mtd[i]->resume(info->mtd[i]);
> + if (info->mtd[i]->resume)
> + info->mtd[i]->resume(info->mtd[i]);
>
> return 0;
> }
> @@ -225,8 +227,9 @@ static void physmap_flash_shutdown(struct platform_device *dev)
> int i;
>
> for (i = 0; i < MAX_RESOURCES && info->mtd[i]; i++)
> - if (info->mtd[i]->suspend(info->mtd[i]) == 0)
> - info->mtd[i]->resume(info->mtd[i]);
> + if (info->mtd[i]->suspend && info->mtd[i]->resume)
> + if (info->mtd[i]->suspend(info->mtd[i]) == 0)
> + info->mtd[i]->resume(info->mtd[i]);
> }
> #else
> #define physmap_flash_suspend NULL
> --
> 1.5.5.3
>
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
Jörn
--
It is the mark of an educated mind to be able to entertain a thought
without accepting it.
-- Aristotle
prev parent reply other threads:[~2008-06-16 13:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-07 15:01 physmap without MTD partitions Robert Jarzmik
2008-06-16 9:50 ` Jörn Engel
2008-06-16 12:34 ` Robert Jarzmik
2008-06-16 13:08 ` Jörn Engel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080616130810.GA20814@logfs.org \
--to=joern@logfs.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rjarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox