From: David Brownell <david-b@pacbell.net>
To: "Kyungmin Park" <kmpark@infradead.org>
Cc: Bryan Wu <cooloney@kernel.org>,
linux-mtd@lists.infradead.org,
lkml <linux-kernel@vger.kernel.org>,
Michael Hennerich <michael.hennerich@analog.com>
Subject: Re: [patch 2.6.26-rc8+] mtd: dataflash OTP support
Date: Sun, 29 Jun 2008 22:03:14 -0700 [thread overview]
Message-ID: <200806292203.15123.david-b@pacbell.net> (raw)
In-Reply-To: <9c9fda240806292114m43d4e940h3346c03d92d65b32@mail.gmail.com>
On Sunday 29 June 2008, Kyungmin Park wrote:
> > +#ifdef CONFIG_MTD_OTP
> > +#define HAVE_OTP
> > +#endif
> > +
> > +#ifdef CONFIG_MTD_ONENAND_OTP
> > +#define HAVE_OTP
> > +#endif
> > +
> > +#ifdef CONFIG_MTD_DATAFLASH_OTP
> > +#define HAVE_OTP
> > +#endif
> > +
>
> How about to add these at Kconfig like this,
>
> config MTD_HAVE_OTP
> bool
> default n
>
> and NOR, OneNAND, and DATAFLASH select MTD_HAVE_OTP if OTP support.
Shouldn't it be HAVE_MTD_OTP?
That'd be prettier, yes. MTD_OTP would have been the obvious
choice for the generic symbol, but that's specific to CFI.
(And for that matter, CFI command set 1 ... I have set 2 chips
that can't yet expose their OTP data!)
I'd rather see that as a separate patch though -- either before
or after this one, I don't much care.
- Dave
prev parent reply other threads:[~2008-06-30 5:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 3:19 [patch 2.6.26-rc8+] mtd: dataflash OTP support David Brownell
2008-06-30 4:14 ` Kyungmin Park
2008-06-30 5:03 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806292203.15123.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=cooloney@kernel.org \
--cc=kmpark@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox