From: Jens Axboe <jens.axboe@oracle.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: mano@roarinelk.homelinux.net, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: MTD kobject warnings due to block layer changes
Date: Fri, 29 Aug 2008 08:44:16 +0200 [thread overview]
Message-ID: <20080829064415.GJ20055@kernel.dk> (raw)
In-Reply-To: <20080829153929B.fujita.tomonori@lab.ntt.co.jp>
On Fri, Aug 29 2008, FUJITA Tomonori wrote:
> On Fri, 29 Aug 2008 08:29:34 +0200
> Jens Axboe <jens.axboe@oracle.com> wrote:
>
> > On Fri, Aug 29 2008, FUJITA Tomonori wrote:
> > > On Thu, 28 Aug 2008 12:09:21 +0200
> > > Jens Axboe <jens.axboe@oracle.com> wrote:
> > >
> > > > On Thu, Aug 28 2008, Manuel Lauss wrote:
> > > > > Hello,
> > > > >
> > > > > Todays -git spits out these wanings during boot, caused by
> > > > > Commit abf5439370491dd6fbb4fe1a7939680d2a9bc9d4
> > > > > ( block: move cmdfilter from gendisk to request_queue ):
> > > > >
> > > > > Using physmap partition information
> > > > > Creating 3 MTD partitions on "physmap-flash":
> > > > > 0x00000000-0x01c00000 : "User FS"
> > > > > 0x01c00000-0x01c40000 : "booter"
> > > > > kobject (8511c410): tried to init an initialized object, something is seriously wrong.
> > > > > Call Trace:
> > > > > [<8036644c>] dump_stack+0x8/0x34
> > > > > [<8021f050>] kobject_init+0x50/0xcc
> > > > > [<8021fa18>] kobject_init_and_add+0x24/0x58
> > > > > [<8021d20c>] blk_register_filter+0x4c/0x64
> > > > > [<8021c194>] add_disk+0x78/0xe0
> > > > > [<8027d14c>] add_mtd_blktrans_dev+0x254/0x278
> > > > > [<8027c8f0>] blktrans_notify_add+0x40/0x78
> > > > > [<80279c00>] add_mtd_device+0xd0/0x150
> > > > > [<8027b090>] add_mtd_partitions+0x568/0x5d8
> > > > > [<80285458>] physmap_flash_probe+0x2ac/0x334
> > > > > [<802644f8>] driver_probe_device+0x12c/0x244
> > > > > [<8026465c>] __driver_attach+0x4c/0x84
> > > > > [<80263c64>] bus_for_each_dev+0x58/0xac
> > > > > [<802633ec>] bus_add_driver+0xc4/0x24c
> > > > > [<802648e0>] driver_register+0xcc/0x184
> > > > > [<80100460>] _stext+0x60/0x1bc
> > > > >
> > > > > 0x01c40000-0x01fe0000 : "vmlinux.elf"
> > > > > kobject (8511c410): tried to init an initialized object, something is seriously wrong.
> > > > > Call Trace:
> > > > > [<8036644c>] dump_stack+0x8/0x34
> > > > > [<8021f050>] kobject_init+0x50/0xcc
> > > > > [<8021fa18>] kobject_init_and_add+0x24/0x58
> > > > > [<8021d20c>] blk_register_filter+0x4c/0x64
> > > > > [<8021c194>] add_disk+0x78/0xe0
> > > > > [<8027d14c>] add_mtd_blktrans_dev+0x254/0x278
> > > > > [<8027c8f0>] blktrans_notify_add+0x40/0x78
> > > > > [<80279c00>] add_mtd_device+0xd0/0x150
> > > > > [<8027b090>] add_mtd_partitions+0x568/0x5d8
> > > > > [<80285458>] physmap_flash_probe+0x2ac/0x334
> > > > > [<802644f8>] driver_probe_device+0x12c/0x244
> > > > > [<8026465c>] __driver_attach+0x4c/0x84
> > > > > [<80263c64>] bus_for_each_dev+0x58/0xac
> > > > > [<802633ec>] bus_add_driver+0xc4/0x24c
> > > > > [<802648e0>] driver_register+0xcc/0x184
> > > > > [<80100460>] _stext+0x60/0x1bc
> > > > >
> > > > > NAND device: Manufacturer ID: 0xec, Chip ID: 0xf1 (Samsung NAND 128MiB 3,3V 8-bit)
> > > > > Scanning device for bad blocks
> > > > > Creating 1 MTD partitions on "gen_nand":
> > > > > 0x00000000-0x08000000 : "NAND FS 0"
> > > > > kobject (8511c410): tried to init an initialized object, something is seriously wrong.
> > > > > Call Trace:
> > > > > [<8036644c>] dump_stack+0x8/0x34
> > > > > [<8021f050>] kobject_init+0x50/0xcc
> > > > > [<8021fa18>] kobject_init_and_add+0x24/0x58
> > > > > [<8021d20c>] blk_register_filter+0x4c/0x64
> > > > > [<8021c194>] add_disk+0x78/0xe0
> > > > > [<8027d14c>] add_mtd_blktrans_dev+0x254/0x278
> > > > > [<8027c8f0>] blktrans_notify_add+0x40/0x78
> > > > > [<80279c00>] add_mtd_device+0xd0/0x150
> > > > > [<8027b090>] add_mtd_partitions+0x568/0x5d8
> > > > > [<804016b0>] plat_nand_probe+0x1e8/0x24c
> > > > > [<802644f8>] driver_probe_device+0x12c/0x244
> > > > > [<8026465c>] __driver_attach+0x4c/0x84
> > > > > [<80263c64>] bus_for_each_dev+0x58/0xac
> > > > > [<802633ec>] bus_add_driver+0xc4/0x24c
> > > > > [<802648e0>] driver_register+0xcc/0x184
> > > > > [<80100460>] _stext+0x60/0x1bc
> > > >
> > > > Tomo? I don't see how this is happening. The queue is properly zeroed,
> > > > so no chance ->state_initialized being crap.
> > >
> > > With MTD, multiple gendisks share a single request_queue?
> >
> > Irk, sure looks that way. I thougt we had disbanded with that years ago,
> > it's generally not a "supported" configuration.
>
> How about moving blk_register_filter(disk) from add_disk to sd.c and
> sr.c, etc, which want the command filter support?
Yeah, I think that's the quick'n dirty to fix this one.
--
Jens Axboe
next prev parent reply other threads:[~2008-08-29 6:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 8:46 MTD kobject warnings due to block layer changes Manuel Lauss
2008-08-28 10:09 ` Jens Axboe
2008-08-29 5:56 ` FUJITA Tomonori
2008-08-29 6:29 ` Jens Axboe
2008-08-29 6:39 ` FUJITA Tomonori
2008-08-29 6:44 ` Jens Axboe [this message]
2008-08-29 6:47 ` FUJITA Tomonori
2008-08-29 6:50 ` Jens Axboe
2008-08-29 7:56 ` FUJITA Tomonori
2008-08-29 8:01 ` Jens Axboe
2008-08-29 8:19 ` FUJITA Tomonori
2008-08-29 8:34 ` Manuel Lauss
2008-08-29 9:45 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080829064415.GJ20055@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mano@roarinelk.homelinux.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox