public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
	Mike Frysinger <vapier.adi@gmail.com>,
	Russ Dill <russ.dill@gmail.com>,
	Jamie Lokier <jamie@shareable.org>,
	Ben Dooks <ben-linux-arm@fluff.org>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	Mike Rapoport <mike@compulab.co.il>
Subject: Re: [PATCH] [MTD] [NAND] GPIO NAND flash driver
Date: Sun, 12 Oct 2008 11:43:50 +0100	[thread overview]
Message-ID: <20081012104349.GC29975@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1223807730.6770.387.camel@macbook.infradead.org>

On Sun, Oct 12, 2008 at 11:35:30AM +0100, David Woodhouse wrote:
> On Sun, 2008-10-12 at 11:13 +0100, Russell King - ARM Linux wrote:
> > Consider the loudspeaker amplifier example.  Does it
> > matter if the amplifier is powered up for a few milliseconds on boot?
> > No.  
> 
> Sometimes it does. Partly because that usually means it's also powered
> up during wake from suspend -- so you get horrible clicks when resume.
> Which if you suspend as often as OLPC does, for example, is a pain.

As I've pointed out, it's hardware dependent.

If your hardware has "sleep modes" for GPIO which are preserved until
you explicitly release the GPIO hardware from sleep state - giving you
a chance to restore the GPIO registers on resume without the external
hardware seeing glitches - then you set the sleep mode state so the
GPIO for the amplifier is set as an output, and driven to the "powered
down" level.

On hardware which doesn't have that facility, then yes you do want
pull-ups and pull-downs.  But just because your hardware doesn't have
sensible GPIO hardware, that's no reason to outlaw setting GPIOs to
their inactive states while unloading drivers.

  reply	other threads:[~2008-10-12 10:54 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-08  6:01 [PATCH] [MTD] [NAND] GPIO NAND flash driver Mike Rapoport
2008-10-08  6:20 ` Mike Frysinger
2008-10-08  7:28   ` Russell King - ARM Linux
2008-10-08  7:29     ` Mike Frysinger
2008-10-08  8:28       ` Mike Rapoport
2008-10-08 17:41         ` Mike Frysinger
2008-10-10 10:46           ` Mike Rapoport
2008-10-10 14:19             ` Jamie Lokier
2008-10-10 21:48               ` Russell King - ARM Linux
2008-10-10 22:07                 ` Mike Frysinger
2008-10-12  8:02                   ` Mike Rapoport
2008-10-12  8:14                     ` Mike Frysinger
2008-10-12  8:28                       ` Russell King - ARM Linux
2008-10-12  8:56                         ` Mike Frysinger
2008-10-12 10:13                           ` Russell King - ARM Linux
2008-10-12 10:35                             ` David Woodhouse
2008-10-12 10:43                               ` Russell King - ARM Linux [this message]
2008-10-12 15:04                             ` Jamie Lokier
2008-10-12 19:04                             ` Mike Frysinger
2008-10-12 19:09                               ` Russell King - ARM Linux
2008-10-12 19:22                                 ` Mike Frysinger
2008-10-12 19:40                                   ` Russell King - ARM Linux
2008-10-12 10:04                       ` Mike Rapoport
2008-10-13 13:59                     ` David Woodhouse
2008-10-15  6:38                       ` Mike Rapoport
2008-10-15  7:52                         ` Russell King - ARM Linux
2008-10-15  8:25                           ` Mike Rapoport
2008-10-08  8:30     ` David Woodhouse
2008-10-08 14:25 ` Paulius Zaleckas
  -- strict thread matches above, loose matches on Subject: below --
2008-10-19 23:51 David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081012104349.GC29975@flint.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=ben-linux-arm@fluff.org \
    --cc=dwmw2@infradead.org \
    --cc=jamie@shareable.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael.hennerich@analog.com \
    --cc=mike@compulab.co.il \
    --cc=russ.dill@gmail.com \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox