From: David Brownell <david-b@pacbell.net>
To: David Woodhouse <David.Woodhouse@intel.com>,
Chen Gong <g.chen@freescale.com>,
linux-mtd@lists.infradead.org
Subject: goofy mtd m25p80 patches in GIT ...
Date: Sun, 19 Oct 2008 15:35:05 -0700 [thread overview]
Message-ID: <200810191535.05617.david-b@pacbell.net> (raw)
[resend cc'ing linux-mtd, sorry]
I noticed a couple goofy patches in MTD GIT, while poking around
wondering what happened to some patches that I expected would
already have gotten upstream. Details below.
- Dave
First:
http://git.kernel.org/?p=linux/kernel/git/dwmw2/mtd-2.6.git;a=commitdiff;h=faff37508a104e9ec5285d5adecaab7e8dde472a
That patch is goofy because the command in question is *NOT* a block
erase command. It's a chip-erase command ... entirely unlike the
existing *real* block erase commands used in the driver.
Could we get a fix that provides the correct name for the operations?
Having real block commands, and this new thing, is at the very least
confusing...
Second:
http://git.kernel.org/?p=linux/kernel/git/dwmw2/mtd-2.6.git;a=commitdiff;h=75d0ee2202b5740e94e913d8a52f91c6557c4c81
That's just plain wrong ... the original code is correct, but the
patch changed it to be incorrect. (DMA from the stack is never
legal.)
Just revert this one entirely.
next reply other threads:[~2008-10-19 22:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-19 22:35 David Brownell [this message]
2008-10-20 7:32 ` goofy mtd m25p80 patches in GIT Chen Gong-B11801
2008-10-20 8:21 ` David Brownell
2008-10-20 7:40 ` David Woodhouse
2008-10-20 7:42 ` Chen Gong-B11801
2008-10-20 7:44 ` David Woodhouse
2008-10-20 7:56 ` Chen Gong-B11801
2008-10-20 8:02 ` David Woodhouse
2008-10-20 8:16 ` Chen Gong-B11801
2008-10-20 8:30 ` David Brownell
2008-10-20 8:37 ` Chen Gong-B11801
2008-10-20 8:24 ` David Brownell
2008-10-20 8:04 ` David Brownell
2008-10-20 8:12 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810191535.05617.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=David.Woodhouse@intel.com \
--cc=g.chen@freescale.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox