From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp126.sbc.mail.sp1.yahoo.com ([69.147.65.185]) by bombadil.infradead.org with smtp (Exim 4.68 #1 (Red Hat Linux)) id 1Krgrc-0000oW-5p for linux-mtd@lists.infradead.org; Sun, 19 Oct 2008 22:35:08 +0000 To: David Woodhouse , Chen Gong , linux-mtd@lists.infradead.org Subject: goofy mtd m25p80 patches in GIT ... Content-Disposition: inline From: David Brownell Date: Sun, 19 Oct 2008 15:35:05 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200810191535.05617.david-b@pacbell.net> List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , [resend cc'ing linux-mtd, sorry] I noticed a couple goofy patches in MTD GIT, while poking around wondering what happened to some patches that I expected would already have gotten upstream. Details below. - Dave First: http://git.kernel.org/?p=linux/kernel/git/dwmw2/mtd-2.6.git;a=commitdiff;h=faff37508a104e9ec5285d5adecaab7e8dde472a That patch is goofy because the command in question is *NOT* a block erase command. It's a chip-erase command ... entirely unlike the existing *real* block erase commands used in the driver. Could we get a fix that provides the correct name for the operations? Having real block commands, and this new thing, is at the very least confusing... Second: http://git.kernel.org/?p=linux/kernel/git/dwmw2/mtd-2.6.git;a=commitdiff;h=75d0ee2202b5740e94e913d8a52f91c6557c4c81 That's just plain wrong ... the original code is correct, but the patch changed it to be incorrect. (DMA from the stack is never legal.) Just revert this one entirely.