public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: linux-mtd@lists.infradead.org,
	Lennert Buytenhek <buytenh@wantstofly.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] mtd m25p80: add support for Macronix MX25L12805D
Date: Sun, 19 Oct 2008 15:47:45 -0700	[thread overview]
Message-ID: <200810191547.45449.david-b@pacbell.net> (raw)
In-Reply-To: <200810191516.30804.david-b@pacbell.net>

Sorry for the "1/3" -- there's only this one patch.
The other two would have been resends of patches that
never got acked, but do seem to be in the MTD git tree.

However I noticed that this patch will have a problem
applying against that MTD git ... the m25p80 driver
got taught how to use two of the "extended" JEDEC ID
bytes provided by some vendors, so the initializers here
are all missing an extra "u16" value following the JEDEC
code.  Swap in a 0 for the Macronix part and all should
be OK ...

- Dave

On Sunday 19 October 2008, David Brownell wrote:
> From: Lennert Buytenhek <buytenh@wantstofly.org>
> 
> Support one more flavor of SPI flash:  Macronix MX25L12805D
> (128 Mbit, 16 MByte).
> 
> Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> 
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -467,6 +467,9 @@ static struct flash_info __devinitdata m25p_data [] = {
>  	{ "at26df161a", 0x1f4601, 64 * 1024, 32, SECT_4K, },
>  	{ "at26df321",  0x1f4701, 64 * 1024, 64, SECT_4K, },
>  
> +	/* Macronix */
> +	{ "mx25l12805d", 0xc22018, 64 * 1024, 256, SECT_4K, },
> +
>  	/* Spansion -- single (large) sector size only, at least
>  	 * for the chips listed here (without boot sectors).
>  	 */
> 
> 
> 

      reply	other threads:[~2008-10-19 22:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-19 22:16 [PATCH 1/3] mtd m25p80: add support for Macronix MX25L12805D David Brownell
2008-10-19 22:47 ` David Brownell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810191547.45449.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=buytenh@wantstofly.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox