public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: "Chen Gong-B11801" <G.Chen@freescale.com>
Cc: linux-mtd@lists.infradead.org, David Woodhouse <dwmw2@infradead.org>
Subject: Re: goofy mtd m25p80 patches in GIT ...
Date: Mon, 20 Oct 2008 01:30:49 -0700	[thread overview]
Message-ID: <200810200130.50054.david-b@pacbell.net> (raw)
In-Reply-To: <C3C4D3116BA1F84989E53FCF1F505187166DE0@zch01exm21.fsl.freescale.net>

On Monday 20 October 2008, Chen Gong-B11801 wrote:
> I prefer to the first opinion -- renaming 'erase_block' to 'erase_chip',
> it looks more straightforward

*AND* fixing the name of the operation.

The pre-existing erase operations were:

 #define OPCODE_BE_4K            0x20    /* Erase 4KiB block */
 #define OPCODE_BE_32K           0x52    /* Erase 32KiB block */
 #define OPCODE_SE               0xd8    /* Sector erase (usually 64KiB) */

So I'm quite puzzled why you would call the chip erase
opcode a "block erase" opcode ... it's not a 4K block,
not a 32K block, not a sector (of, usually, 64K).

It's more typically something like multiple MBytes.

Having read or skimmed several dozen SPI flash specs,
none of them called chip erase a "block erase" operation.

  reply	other threads:[~2008-10-20  8:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-19 22:35 goofy mtd m25p80 patches in GIT David Brownell
2008-10-20  7:32 ` Chen Gong-B11801
2008-10-20  8:21   ` David Brownell
2008-10-20  7:40 ` David Woodhouse
2008-10-20  7:42   ` Chen Gong-B11801
2008-10-20  7:44     ` David Woodhouse
2008-10-20  7:56       ` Chen Gong-B11801
2008-10-20  8:02         ` David Woodhouse
2008-10-20  8:16           ` Chen Gong-B11801
2008-10-20  8:30             ` David Brownell [this message]
2008-10-20  8:37               ` Chen Gong-B11801
2008-10-20  8:24           ` David Brownell
2008-10-20  8:04   ` David Brownell
2008-10-20  8:12     ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810200130.50054.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=G.Chen@freescale.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox