From: David Brownell <david-b@pacbell.net>
To: Chen Gong <g.chen@freescale.com>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org,
Chen Gong <clumsycg@gmail.com>
Subject: Re: [PATCH] [MTD] m25p80.c erase enhance (v2)
Date: Mon, 20 Oct 2008 21:20:40 -0700 [thread overview]
Message-ID: <200810202120.41193.david-b@pacbell.net> (raw)
In-Reply-To: <1224558909-4254-1-git-send-email-g.chen@freescale.com>
On Monday 20 October 2008, Chen Gong wrote:
> -#define OPCODE_BE 0xc7 /* Erase whole flash block */
> +#define OPCODE_CHIP_ERASE 0xc7 /* Erase whole flash block */
Looks good to me, except that comment should be "Erase whole flash chip". :)
Thanks.
- Dave
prev parent reply other threads:[~2008-10-21 4:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 3:15 [PATCH] [MTD] m25p80.c erase enhance (v2) Chen Gong
2008-10-21 4:20 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810202120.41193.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=clumsycg@gmail.com \
--cc=dwmw2@infradead.org \
--cc=g.chen@freescale.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox