From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org
Cc: dwmw2@infradead.org
Subject: Please fix or remove OMAP2 onenand driver
Date: Sun, 23 Nov 2008 16:50:11 +0000 [thread overview]
Message-ID: <20081123165011.GB17438@flint.arm.linux.org.uk> (raw)
Clearly this driver has been put into mainline prematurely - it takes
no account of the relocation of headers.
It's causing a regression - omap_2430sdp_defconfig used to build in
mainline, and it no longer does.
Please fix, or remove this broken driver from mainline.
drivers/mtd/onenand/omap2.c:38:27: error: asm/arch/gpmc.h: No such file or directory
drivers/mtd/onenand/omap2.c:39:30: error: asm/arch/onenand.h: No such file or directory
drivers/mtd/onenand/omap2.c:40:27: error: asm/arch/gpio.h: No such file or directory
drivers/mtd/onenand/omap2.c:41:25: error: asm/arch/pm.h: No such file or directory
drivers/mtd/onenand/omap2.c:45:26: error: asm/arch/dma.h: No such file or directory
drivers/mtd/onenand/omap2.c:47:28: error: asm/arch/board.h: No such file or directory
drivers/mtd/onenand/omap2.c: In function 'omap2_onenand_wait':
drivers/mtd/onenand/omap2.c:153: error: implicit declaration of function 'omap_get_gpio_datain'
drivers/mtd/onenand/omap2.c: In function 'omap2_onenand_read_bufferram':
drivers/mtd/onenand/omap2.c:469: error: implicit declaration of function 'omap_set_dma_transfer_params'
drivers/mtd/onenand/omap2.c:469: error: 'OMAP_DMA_DATA_TYPE_S32' undeclared (first use in this function)
drivers/mtd/onenand/omap2.c:469: error: (Each undeclared identifier is reported only once
drivers/mtd/onenand/omap2.c:469: error: for each function it appears in.)
drivers/mtd/onenand/omap2.c:471: error: implicit declaration of function 'omap_set_dma_src_params'
drivers/mtd/onenand/omap2.c:471: error: 'OMAP_DMA_AMODE_POST_INC' undeclared (first use in this function)
drivers/mtd/onenand/omap2.c:473: error: implicit declaration of function 'omap_set_dma_dest_params'
drivers/mtd/onenand/omap2.c:477: error: implicit declaration of function 'omap_start_dma'
drivers/mtd/onenand/omap2.c: In function 'omap2_onenand_write_bufferram':
drivers/mtd/onenand/omap2.c:514: error: 'OMAP_DMA_DATA_TYPE_S16' undeclared (first use in this function)
drivers/mtd/onenand/omap2.c:516: error: 'OMAP_DMA_AMODE_POST_INC' undeclared (first use in this function)
drivers/mtd/onenand/omap2.c: In function 'omap2_onenand_probe':
drivers/mtd/onenand/omap2.c:595: error: dereferencing pointer to incomplete type
drivers/mtd/onenand/omap2.c:596: error: dereferencing pointer to incomplete type
drivers/mtd/onenand/omap2.c:597: error: dereferencing pointer to incomplete type
drivers/mtd/onenand/omap2.c:603: error: implicit declaration of function 'gpmc_cs_request'
drivers/mtd/onenand/omap2.c:622: error: dereferencing pointer to incomplete type
drivers/mtd/onenand/omap2.c:623: error: dereferencing pointer to incomplete type
drivers/mtd/onenand/omap2.c:629: error: dereferencing pointer to incomplete type
drivers/mtd/onenand/omap2.c:633: error: implicit declaration of function 'omap_request_gpio'
drivers/mtd/onenand/omap2.c:638: error: implicit declaration of function 'omap_set_gpio_direction'
drivers/mtd/onenand/omap2.c:640: error: implicit declaration of function 'OMAP_GPIO_IRQ'
drivers/mtd/onenand/omap2.c:647: error: implicit declaration of function 'omap_request_dma'
drivers/mtd/onenand/omap2.c:651: error: implicit declaration of function 'omap_set_dma_write_mode'
drivers/mtd/onenand/omap2.c:652: error: 'OMAP_DMA_WRITE_NON_POSTED' undeclared (first use in this function)
drivers/mtd/onenand/omap2.c:653: error: implicit declaration of function 'omap_set_dma_src_data_pack'
drivers/mtd/onenand/omap2.c:654: error: implicit declaration of function 'omap_set_dma_src_burst_mode'
drivers/mtd/onenand/omap2.c:655: error: 'OMAP_DMA_DATA_BURST_8' undeclared (first use in this function)
drivers/mtd/onenand/omap2.c:656: error: implicit declaration of function 'omap_set_dma_dest_data_pack'
drivers/mtd/onenand/omap2.c:657: error: implicit declaration of function 'omap_set_dma_dest_burst_mode'
drivers/mtd/onenand/omap2.c:708: error: dereferencing pointer to incomplete type
drivers/mtd/onenand/omap2.c:709: error: dereferencing pointer to incomplete type
drivers/mtd/onenand/omap2.c:710: error: dereferencing pointer to incomplete type
drivers/mtd/onenand/omap2.c:725: error: implicit declaration of function 'omap_free_dma'
drivers/mtd/onenand/omap2.c:730: error: implicit declaration of function 'omap_free_gpio'
drivers/mtd/onenand/omap2.c:736: error: implicit declaration of function 'gpmc_cs_free'
make[3]: *** [drivers/mtd/onenand/omap2.o] Error 1
next reply other threads:[~2008-11-23 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-23 16:50 Russell King - ARM Linux [this message]
2008-11-24 11:37 ` Please fix or remove OMAP2 onenand driver Adrian Hunter
2008-11-24 12:01 ` Russell King - ARM Linux
2008-11-24 12:44 ` Adrian Hunter
2008-11-26 9:57 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081123165011.GB17438@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox