* [PATCH] add missing cmdset field in PXA3xx NAND code
@ 2008-12-01 11:57 Daniel Mack
2008-12-01 13:00 ` Eric Miao
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Mack @ 2008-12-01 11:57 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: linux-mtd
This adds a missing .cmdset parameter for STM 2G NAND chip
definition. Even though support for built-in NAND chips is
marked deprecated, the driver crashes in __readid() due to a NULL
pointer dereference if it's not there.
Signed-off-by: Daniel Mack <daniel@caiaq.de>
diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
index c0fa9c9..ff4d28e 100644
--- a/drivers/mtd/nand/pxa3xx_nand.c
+++ b/drivers/mtd/nand/pxa3xx_nand.c
@@ -269,6 +269,7 @@ static struct pxa3xx_nand_timing stm2GbX16_timing = {
static struct pxa3xx_nand_flash stm2GbX16 = {
.timing = &stm2GbX16_timing,
+ .cmdset = &largepage_cmdset,
.page_per_block = 64,
.page_size = 2048,
.flash_width = 16,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] add missing cmdset field in PXA3xx NAND code
2008-12-01 11:57 [PATCH] add missing cmdset field in PXA3xx NAND code Daniel Mack
@ 2008-12-01 13:00 ` Eric Miao
0 siblings, 0 replies; 2+ messages in thread
From: Eric Miao @ 2008-12-01 13:00 UTC (permalink / raw)
To: Daniel Mack; +Cc: linux-mtd, linux-arm-kernel
On Mon, Dec 1, 2008 at 7:57 PM, Daniel Mack <daniel@caiaq.de> wrote:
> This adds a missing .cmdset parameter for STM 2G NAND chip
> definition. Even though support for built-in NAND chips is
> marked deprecated, the driver crashes in __readid() due to a NULL
> pointer dereference if it's not there.
>
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
Thanks, however this is a bit later, some one spotted this earlier:
http://lists.infradead.org/pipermail/linux-mtd/2008-November/023643.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-01 13:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-01 11:57 [PATCH] add missing cmdset field in PXA3xx NAND code Daniel Mack
2008-12-01 13:00 ` Eric Miao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox