public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom.net>
To: Julia Lawall <julia@diku.dk>
Cc: linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org,
	dwmw2@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/mtd/nand/pasemi_nand.c: Add missing pci_dev_put
Date: Mon, 1 Dec 2008 12:08:12 -0600	[thread overview]
Message-ID: <20081201180812.GA21646@lixom.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0812011838440.11341@pc-004.diku.dk>

On Mon, Dec 01, 2008 at 06:39:01PM +0100, Julia Lawall wrote:
> On Mon, 1 Dec 2008, Olof Johansson wrote:
> 
> > On Thu, Nov 27, 2008 at 01:19:49PM +0100, Julia Lawall wrote:
> > > From: Julia Lawall <julia@diku.dk>
> > > 
> > > pci_get_device increments a reference count that should be decremented
> > > using pci_dev_put.  I have thus added an extra label in the error handling
> > > code to do this.  I don't know, however, whether there should be a
> > > pci_dev_put before the return 0 as well.
> > > 
> > [...]
> > 
> > > Signed-off-by: Julia Lawall <julia@diku.dk>
> > 
> > Acked-by: Olof Johansson <olof@lixom.net>
> 
> Do you know the answer about the return 0?

Teaches me to read the patch description twice.

Either there or in pasemi_nand_remove(), doesn't matter much to me. Doing
it before the return 0 is the smaller change.


-Olof

  reply	other threads:[~2008-12-01 17:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-27 12:19 [PATCH] drivers/mtd/nand/pasemi_nand.c: Add missing pci_dev_put Julia Lawall
2008-12-01 17:43 ` Olof Johansson
2008-12-01 17:39   ` Julia Lawall
2008-12-01 18:08     ` Olof Johansson [this message]
2008-12-01 18:03       ` Julia Lawall
2008-12-01 20:11       ` Julia Lawall
2008-12-01 21:57         ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081201180812.GA21646@lixom.net \
    --to=olof@lixom.net \
    --cc=dwmw2@infradead.org \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox