From: Wolfram Sang <w.sang@pengutronix.de>
To: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: Add open firmware GPIO NAND driver
Date: Mon, 26 Jan 2009 21:10:00 +0100 [thread overview]
Message-ID: <20090126201000.GA21294@pengutronix.de> (raw)
In-Reply-To: <200901260907.05825.matthias.fuchs@esd-electronics.com>
[-- Attachment #1: Type: text/plain, Size: 780 bytes --]
Hi Matthias,
On Mon, Jan 26, 2009 at 09:07:05AM +0100, Matthias Fuchs wrote:
> first I thought about adding the device tree code to the platform driver.
> But if you look at the code you will see that there are many places where
> the drivers differ. Merging my code with the platform driver will bring a lot of #ifdefs
> and I do not like that! The identical functions are only a very few lines.
Okay, that's why I asked :) When I did the of-version of mtd-ram, it was
luckily possible to make a generic init function and call them from
both, platform and of. I just wanted to know if such an approach was
considered.
Regards,
Wolfram
--
Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de
Pengutronix - Linux Solutions for Science and Industry
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2009-01-26 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-25 17:01 [PATCH] mtd: Add open firmware GPIO NAND driver Matthias Fuchs
2009-01-25 19:27 ` Wolfram Sang
2009-01-26 8:07 ` Matthias Fuchs
2009-01-26 20:10 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090126201000.GA21294@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=matthias.fuchs@esd-electronics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox