From: Mike Frysinger <vapier@gentoo.org>
To: Adrian McMenamin <adrian@newgolddream.dyndns.info>
Cc: linux-sh <linux-sh@vger.kernel.org>, Greg KH <greg@kroah.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Paul Mundt <lethal@linux-sh.org>,
MTD <linux-mtd@lists.infradead.org>,
linux-input <linux-input@vger.kernel.org>,
dwmw2 <dwmw2@infradead.org>
Subject: Re: [PATCH RFC] sh: maple: Add support for SEGA Dreamcast VMU and clean up maple bus driver (3/3)
Date: Thu, 29 Jan 2009 00:46:05 -0500 [thread overview]
Message-ID: <200901290046.07659.vapier@gentoo.org> (raw)
In-Reply-To: <1233188287.6734.32.camel@localhost.localdomain>
On Wednesday 28 January 2009 19:18:07 Adrian McMenamin wrote:
> --- a/drivers/input/keyboard/maple_keyb.c
> +++ b/drivers/input/keyboard/maple_keyb.c
> - if (!kbd || !idev) {
> - error = -ENOMEM;
> + if (!kbd) {
> + error = ENOMEM;
> goto fail;
> }
> ...
> - return error;
> +fail:
> + return -error;
this driver has the weird/broken error inverting other patches of yours have
had recently ... that stuff really needs to stop showing up ;)
-mike
next prev parent reply other threads:[~2009-01-29 5:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1233186456.6734.16.camel@localhost.localdomain>
[not found] ` <1233187069.6734.21.camel@localhost.localdomain>
2009-01-29 0:09 ` [PATCH RFC] sh: maple: Add support for SEGA Dreamcast VMU and clean up maple bus driver (2/3) Adrian McMenamin
2009-01-29 0:18 ` [PATCH RFC] sh: maple: Add support for SEGA Dreamcast VMU and clean up maple bus driver (3/3) Adrian McMenamin
2009-01-29 2:57 ` Paul Mundt
2009-01-29 10:34 ` Adrian McMenamin
2009-01-29 5:46 ` Mike Frysinger [this message]
2009-01-29 0:44 ` [PATCH RFC] sh: maple: Add support for SEGA Dreamcast VMU and clean up maple bus driver (2/3) Mike Frysinger
2009-01-29 0:49 ` Adrian McMenamin
2009-01-29 1:12 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901290046.07659.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=adrian@newgolddream.dyndns.info \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=greg@kroah.com \
--cc=lethal@linux-sh.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox