From: Andrew Morton <akpm@linux-foundation.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mtd@lists.infradead.org, cooloney@kernel.org,
dwmw2@infradead.org, vapier.adi@gmail.com
Subject: Re: [patch for 2.6.29? 4/4] mtd/maps: blackfin async flash maps: fix up memory leak
Date: Wed, 11 Feb 2009 16:42:47 -0800 [thread overview]
Message-ID: <20090211164247.8119de8d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090212.093531.235975795.nemoto@toshiba-tops.co.jp>
On Thu, 12 Feb 2009 09:35:31 +0900 (JST)
Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> On Wed, 11 Feb 2009 13:12:19 -0800, akpm@linux-foundation.org wrote:
> > @@ -170,6 +170,7 @@ static int __devinit bfin_flash_probe(st
> > if (ret > 0) {
> > pr_devinit(KERN_NOTICE DRIVER_NAME ": Using commandline partition definition\n");
> > add_mtd_partitions(state->mtd, pdata->parts, ret);
> > + kfree(pdata->parts);
> >
> > } else if (pdata->nr_parts) {
> > pr_devinit(KERN_NOTICE DRIVER_NAME ": Using board partition definition\n");
>
> As Matthias Kaehlcke pointed out in mail titled "[BUG]
> physmap_flash_probe() frees memory still in use", this fix introduce
> another bug.
>
> Revised patch for physmap driver is:
> http://lists.infradead.org/pipermail/linux-mtd/2009-February/024590.html
>
> Mike, please update this blackfin patch too.
>
I don't have a copy of that patch. You're on you own, guys..
next prev parent reply other threads:[~2009-02-12 0:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 21:12 [patch for 2.6.29? 4/4] mtd/maps: blackfin async flash maps: fix up memory leak akpm
2009-02-12 0:35 ` Atsushi Nemoto
2009-02-12 0:42 ` Andrew Morton [this message]
2009-02-14 8:57 ` David Woodhouse
2009-02-17 20:02 ` Mike Frysinger
2009-02-19 0:37 ` Atsushi Nemoto
2009-02-19 1:19 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090211164247.8119de8d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=cooloney@kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox