From: Lennert Buytenhek <buytenh@wantstofly.org>
To: David Howells <dhowells@redhat.com>
Cc: linux-mtd@lists.infradead.org, David Woodhouse <dwmw2@infradead.org>
Subject: Re: Bug in physmap driver?
Date: Thu, 16 Apr 2009 17:14:33 +0200 [thread overview]
Message-ID: <20090416151433.GS1760@mail.wantstofly.org> (raw)
In-Reply-To: <11416.1239894581@redhat.com>
On Thu, Apr 16, 2009 at 04:09:41PM +0100, David Howells wrote:
> > That would suggest that dev->resource[i].end is off-by-one?
>
> Actually, that's a good question: should end be one after the last useful
> addres, or should it be that last useful address?
The last useful address. That's what the resource code expects, as
e.g. two regions with start=00100000,end=00200000 and
start=00200000,end=00300000 will conflict (registration of the second
will fail), whereas if you change the end addresses to 001fffff and
002fffff, they will no longer conflict.
And e.g. /proc/iomem on my x86 box has:
c4000000-c40fffff : PCI Bus #01
dff00000-efefffff : PCI Bus #05
ff500000-ff5fffff : PCI Bus #01
ff600000-ff6fffff : PCI Bus #02
ff700000-ff7fffff : PCI Bus #03
ff800000-ff8fffff : PCI Bus #04
ff900000-ff9fffff : PCI Bus #05
next prev parent reply other threads:[~2009-04-16 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 15:00 Bug in physmap driver? David Howells
2009-04-16 15:06 ` Lennert Buytenhek
2009-04-16 15:09 ` David Howells
2009-04-16 15:14 ` Lennert Buytenhek [this message]
2009-04-16 15:27 ` David Howells
2009-04-16 16:23 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090416151433.GS1760@mail.wantstofly.org \
--to=buytenh@wantstofly.org \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox