From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from n19.bullet.mail.mud.yahoo.com ([68.142.206.146]) by bombadil.infradead.org with smtp (Exim 4.69 #1 (Red Hat Linux)) id 1M1zdF-000450-O6 for linux-mtd@lists.infradead.org; Thu, 07 May 2009 09:11:19 +0000 From: David Brownell To: "vimal singh" Subject: Re: [PATCH 2/2] NAND on DM355: Add 4-bit ECC support for large page NAND chips Date: Thu, 7 May 2009 02:11:05 -0700 References: <46149.192.168.10.89.1241686785.squirrel@dbdmail.itg.ti.com> In-Reply-To: <46149.192.168.10.89.1241686785.squirrel@dbdmail.itg.ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Content-Disposition: inline Message-Id: <200905070211.05491.david-b@pacbell.net> Cc: davinci-linux-open-source@linux.davincidsp.com, nsnehaprabha@ti.com, linux-mtd@lists.infradead.org, akpm@linux-foundation.org, dwmw2@infradead.org, tglx@linutronix.de List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thursday 07 May 2009, vimal singh wrote: > > Comments would be good, highlighting (a) byte 5 is reserved, > > it's the manufacturer bad block marker, (b) 8 bytes @16 are > > expected by JFFS2.  Not everyone will "just know" those. > > How about leaving bytes '4' and '5' for bad block marker, to support 16-bit > NAND parts too. This 4-bit ECC engine only works for 8-bit wide parts ... or are you suggesting that in case TI re-engineers that engine in the future?