public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
* [patch 2.6.30-rc5+] davinci_nand: cmdlinepart uses MTD IDs
@ 2009-05-12 23:23 David Brownell
  2009-05-15 14:13 ` Artem Bityutskiy
  0 siblings, 1 reply; 2+ messages in thread
From: David Brownell @ 2009-05-12 23:23 UTC (permalink / raw)
  To: Linux MTD; +Cc: Andrew Morton, Snehaprabha Narnakaje

From: David Brownell <dbrownell@users.sourceforge.net>

Remove some legacy code from the davinci_nand driver, which made
cmdlinepart ignore the the MTD ID passed to it.  Boards can have
multiple NAND chips, and some do (like the DM357 EVM), so this
dated hack is undesirable.

Correct labels a"re like davinci_nand.0" (for chipselect 0).

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
 drivers/mtd/nand/davinci_nand.c |   11 -----------
 1 file changed, 11 deletions(-)

--- a/drivers/mtd/nand/davinci_nand.c
+++ b/drivers/mtd/nand/davinci_nand.c
@@ -718,19 +718,8 @@ syndrome_done:
 			static const char *probes[] __initconst =
 				{ "cmdlinepart", NULL };
 
-			const char		*master_name;
-
-			/* Set info->mtd.name = 0 temporarily */
-			master_name		= info->mtd.name;
-			info->mtd.name		= (char *)0;
-
-			/* info->mtd.name == 0, means: don't bother checking
-			   <mtd-id> */
 			mtd_parts_nb = parse_mtd_partitions(&info->mtd, probes,
 							    &mtd_parts, 0);
-
-			/* Restore info->mtd.name */
-			info->mtd.name = master_name;
 		}
 
 		if (mtd_parts_nb <= 0) {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 2.6.30-rc5+] davinci_nand: cmdlinepart uses MTD IDs
  2009-05-12 23:23 [patch 2.6.30-rc5+] davinci_nand: cmdlinepart uses MTD IDs David Brownell
@ 2009-05-15 14:13 ` Artem Bityutskiy
  0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2009-05-15 14:13 UTC (permalink / raw)
  To: David Brownell; +Cc: Snehaprabha Narnakaje, Andrew Morton, Linux MTD

On Tue, 2009-05-12 at 16:23 -0700, David Brownell wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
> 
> Remove some legacy code from the davinci_nand driver, which made
> cmdlinepart ignore the the MTD ID passed to it.  Boards can have
> multiple NAND chips, and some do (like the DM357 EVM), so this
> dated hack is undesirable.
> 
> Correct labels a"re like davinci_nand.0" (for chipselect 0).
> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Taken to l2-mtd-2.6.git.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-05-15 14:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-12 23:23 [patch 2.6.30-rc5+] davinci_nand: cmdlinepart uses MTD IDs David Brownell
2009-05-15 14:13 ` Artem Bityutskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox